Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding centOS tag #4326

Closed
wants to merge 3 commits into from
Closed

Adding centOS tag #4326

wants to merge 3 commits into from

Conversation

arthurdm
Copy link
Contributor

@arthurdm arthurdm commented May 7, 2018

Adding a tag for CentOS-based image. This image runs as non-root, which allows it to run in restricted environments such as OpenShift.

This image is also important for developers that want to use CentOS for dev and RHEL for production.

Adding a tag for CentOS-based image
@tianon
Copy link
Member

tianon commented May 7, 2018

This Dockerfile includes COPY --from=websphere-liberty:kernel ... which suffers from the same issues as multi-stage builds (enumerated/discussed over in #3383 (comment)).

@arthurdm
Copy link
Contributor Author

arthurdm commented May 7, 2018

Thx @tianon - I added a comment in that issue.

@tianon
Copy link
Member

tianon commented May 7, 2018 via email

@arthurdm
Copy link
Contributor Author

arthurdm commented May 8, 2018

Yes, you're correct that for Java and Liberty it doesn't matter as much which OS is under (as long as it's one of the supported OS).

There were two issues though:

  1. There wasn't any pattern for customers to follow to build a Dockerfile that contained IBM's JRE + Liberty + an OS that wasn't Ubuntu or Alpine. So we have seen customers build many incorrect Dockerfiles trying to get OS such as CentOS and RHEL to work - many times using OpenJDK instead of IBM's JRE because it was easier to get that. There's a lot of performance benefits for using the combo (JRE + Liberty), so we wanted to ensure we have a Dockerfile (and image) that had that.

  2. Customers that deploy into OpenShift need an image that runs as non-root. Our new CentOS based image (which is popular OS for such platform) accomplishes that.

@arthurdm
Copy link
Contributor Author

hi @tianon - any updates on this?

@yosifkit
Copy link
Member

This comment still applies: #4326 (comment). Unfortunately, none of our tooling can handle multi-stage builds including just COPY --from another official image.

@arthurdm
Copy link
Contributor Author

ok. thanks @yosifkit - I will close this PR then.

@arthurdm arthurdm closed this May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants