Registry 2.5.0-rc2 #1923
Merged
Registry 2.5.0-rc2 #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you want to drop rc1? |
warning: insecure protocol git:// detected: git://github.com/docker/distribution-library-image
diff --git a/registry_2.5.0-rc.1/Dockerfile b/registry_2.5.0-rc.2/Dockerfile
similarity index 100%
copy from registry_2.5.0-rc.1/Dockerfile
copy to registry_2.5.0-rc.2/Dockerfile
diff --git a/registry_2.5.0-rc.1/docker-entrypoint.sh b/registry_2.5.0-rc.2/docker-entrypoint.sh
similarity index 100%
copy from registry_2.5.0-rc.1/docker-entrypoint.sh
copy to registry_2.5.0-rc.2/docker-entrypoint.sh
diff --git a/registry_2.5.0-rc.1/registry/config-example.yml b/registry_2.5.0-rc.2/registry/config-example.yml
similarity index 100%
copy from registry_2.5.0-rc.1/registry/config-example.yml
copy to registry_2.5.0-rc.2/registry/config-example.yml
diff --git a/registry_2.5.0-rc.1/registry/registry b/registry_2.5.0-rc.2/registry/registry
similarity index 74%
copy from registry_2.5.0-rc.1/registry/registry
copy to registry_2.5.0-rc.2/registry/registry
index a0ed916..f068605 100755
Binary files a/registry_2.5.0-rc.1/registry/registry and b/registry_2.5.0-rc.2/registry/registry differ |
|
I was going to drop all RCs when I make the release. Is it much of a pain to have rc1 still in there? |
|
It just causes unnecessary rebuilds and lists it under "supported tags" on
the Hub description (which isn't strictly accurate given that old RCs are
no longer actually supported).
|
Signed-off-by: Richard Scothern <[email protected]>
RichardScothern
force-pushed
the
registry-2.5-rc2
branch
from
8a00b31 to
a2902f3
Compare
|
OK. Removed. |
|
LGTM 👍 |
|
Build test of #1923; a2902f3 ( $ bashbrew build registry:2
warning: insecure protocol git:// detected: git://github.com/docker/distribution-library-image
Building bashbrew/cache:34577de93094b1479c6091bcd016f4e2c806221b62f96222df431b3b77ac3b6b (registry:2)
Tagging registry:2
Tagging registry:2.4
Tagging registry:2.4.1
$ test/run.sh registry:2
testing registry:2
'utc' [1/4]...passed
'cve-2014--shellshock' [2/4]...passed
'no-hard-coded-passwords' [3/4]...passed
'override-cmd' [4/4]...Error: unknown command "echo"
Run 'registry help' for usage.
failed
$ bashbrew build registry:2.5.0-rc.2
Building bashbrew/cache:4b182262423a0c5ef87730aa9311a987c27e16b0021972fa99b160841879c68c (registry:2.5.0-rc.2)
Tagging registry:2.5.0-rc.2
$ test/run.sh registry:2.5.0-rc.2
testing registry:2.5.0-rc.2
'utc' [1/4]...passed
'cve-2014--shellshock' [2/4]...passed
'no-hard-coded-passwords' [3/4]...passed
'override-cmd' [4/4]...passed
The following images failed at least one test: registry:2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎈
Signed-off-by: Richard Scothern [email protected]