Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jruby fix #1413

Merged
merged 2 commits into from
Feb 9, 2016
Merged

Jruby fix #1413

merged 2 commits into from
Feb 9, 2016

Conversation

cpuguy83
Copy link
Contributor

@cpuguy83 cpuguy83 commented Feb 4, 2016

No description provided.

Signed-off-by: Brian Goff <[email protected]>
@tianon
Copy link
Member

tianon commented Feb 4, 2016

Bundler, nooooooooo:

$ ./tests/ruby-bundler/run.sh jruby:latest
Fetching gem metadata from https://rubygems.org/.........
Fetching version metadata from https://rubygems.org/..
Resolving dependencies...

Bundler::GemspecError: Could not read gem at /tmp/tmp.GDCTTnl1h2/cache/diff-lcs-1.2.5.gem. It may be corrupted.

Bundler::GemspecError: Could not read gem at /tmp/tmp.GDCTTnl1h2/cache/nokogiri-1.6.7.2-java.gem. It may be corrupted.

Bundler::GemspecError: Could not read gem at /tmp/tmp.GDCTTnl1h2/cache/rack-1.6.4.gem. It may be corrupted.

Bundler::GemspecError: Could not read gem at /tmp/tmp.GDCTTnl1h2/cache/rspec-support-3.4.1.gem. It may be corrupted.
Using bundler 1.11.2
An error occurred while installing diff-lcs (1.2.5), and Bundler cannot
continue.
Make sure that `gem install diff-lcs -v '1.2.5'` succeeds before bundling.

What even is life? 😞

@tianon
Copy link
Member

tianon commented Feb 4, 2016

Here's the full set of tests:

Build test of #1413; df9587d (jruby):

$ bashbrew build "jruby"
Cloning jruby (git://github.com/cpuguy83/docker-jruby) ...
Processing jruby:latest ...
Processing jruby:9 ...
Processing jruby:9.0 ...
Processing jruby:9.0-jre ...
Processing jruby:9.0.5 ...
Processing jruby:9.0.5-jre ...
Processing jruby:9.0.5.0 ...
Processing jruby:9.0.5.0-jre ...
Processing jruby:9.0-jdk ...
Processing jruby:9.0.5-jdk ...
Processing jruby:9.0.5.0-jdk ...
Processing jruby:9-onbuild ...
Processing jruby:9.0-onbuild ...
Processing jruby:9.0.5-onbuild ...
Processing jruby:9.0.5.0-onbuild ...
Processing jruby:1.7 ...
Processing jruby:1.7.24 ...
Processing jruby:1.7-jre ...
Processing jruby:1.7.24-jre ...
Processing jruby:1.7-jdk ...
Processing jruby:1.7.24-jdk ...
Processing jruby:1.7-onbuild ...
Processing jruby:1.7.24-onbuild ...
$ bashbrew list --uniq "$url" | xargs test/run.sh
testing jruby:latest
    'utc' [1/9]...passed
    'cve-2014--shellshock' [2/9]...passed
    'no-hard-coded-passwords' [3/9]...passed
    'override-cmd' [4/9]...passed
    'ruby-hello-world' [5/9]...passed
    'ruby-standard-libs' [6/9]...passed
    'ruby-gems' [7/9]...WARNING: SSLSocket#session= is not supported
passed
    'ruby-bundler' [8/9]...failed
    'ruby-nonroot' [9/9]...passed
testing jruby:9.0-jdk
    'utc' [1/9]...passed
    'cve-2014--shellshock' [2/9]...passed
    'no-hard-coded-passwords' [3/9]...passed
    'override-cmd' [4/9]...passed
    'ruby-hello-world' [5/9]...passed
    'ruby-standard-libs' [6/9]...passed
    'ruby-gems' [7/9]...passed
    'ruby-bundler' [8/9]...failed
    'ruby-nonroot' [9/9]...passed
testing jruby:9-onbuild
    'override-cmd' [1/1]...passed
testing jruby:1.7
    'utc' [1/9]...passed
    'cve-2014--shellshock' [2/9]...passed
    'no-hard-coded-passwords' [3/9]...passed
    'override-cmd' [4/9]...passed
    'ruby-hello-world' [5/9]...passed
    'ruby-standard-libs' [6/9]...passed
    'ruby-gems' [7/9]...passed
    'ruby-bundler' [8/9]...failed
    'ruby-nonroot' [9/9]...passed
testing jruby:1.7-jdk
    'utc' [1/9]...passed
    'cve-2014--shellshock' [2/9]...passed
    'no-hard-coded-passwords' [3/9]...passed
    'override-cmd' [4/9]...passed
    'ruby-hello-world' [5/9]...passed
    'ruby-standard-libs' [6/9]...passed
    'ruby-gems' [7/9]...passed
    'ruby-bundler' [8/9]...failed
    'ruby-nonroot' [9/9]...passed
testing jruby:1.7-onbuild
    'override-cmd' [1/1]...passed

There is at least one failure in the above build log.

@tianon
Copy link
Member

tianon commented Feb 4, 2016

This is my fault 😞

Fix is in jruby/docker-jruby#14

Signed-off-by: Brian Goff <[email protected]>
@cpuguy83
Copy link
Contributor Author

cpuguy83 commented Feb 9, 2016

re-pushed

@yosifkit
Copy link
Member

yosifkit commented Feb 9, 2016

Changeset: jruby/docker-jruby@13bf613...2448a2d

LGTM, Build test of #1413; 3f28949 (jruby):

$ bashbrew build "jruby"
Cloning jruby (git://github.com/cpuguy83/docker-jruby) ...
Processing jruby:latest ...
Processing jruby:9 ...
Processing jruby:9.0 ...
Processing jruby:9.0-jre ...
Processing jruby:9.0.5 ...
Processing jruby:9.0.5-jre ...
Processing jruby:9.0.5.0 ...
Processing jruby:9.0.5.0-jre ...
Processing jruby:9.0-jdk ...
Processing jruby:9.0.5-jdk ...
Processing jruby:9.0.5.0-jdk ...
Processing jruby:9-onbuild ...
Processing jruby:9.0-onbuild ...
Processing jruby:9.0.5-onbuild ...
Processing jruby:9.0.5.0-onbuild ...
Processing jruby:1.7 ...
Processing jruby:1.7.24 ...
Processing jruby:1.7-jre ...
Processing jruby:1.7.24-jre ...
Processing jruby:1.7-jdk ...
Processing jruby:1.7.24-jdk ...
Processing jruby:1.7-onbuild ...
Processing jruby:1.7.24-onbuild ...
$ bashbrew list --uniq "$url" | xargs test/run.sh
testing jruby:latest
    'utc' [1/9]...passed
    'cve-2014--shellshock' [2/9]...passed
    'no-hard-coded-passwords' [3/9]...passed
    'override-cmd' [4/9]...passed
    'ruby-hello-world' [5/9]...passed
    'ruby-standard-libs' [6/9]...passed
    'ruby-gems' [7/9]...passed
    'ruby-bundler' [8/9]...passed
    'ruby-nonroot' [9/9]...passed
testing jruby:9.0-jdk
    'utc' [1/9]...passed
    'cve-2014--shellshock' [2/9]...passed
    'no-hard-coded-passwords' [3/9]...passed
    'override-cmd' [4/9]...passed
    'ruby-hello-world' [5/9]...passed
    'ruby-standard-libs' [6/9]...passed
    'ruby-gems' [7/9]...passed
    'ruby-bundler' [8/9]...passed
    'ruby-nonroot' [9/9]...passed
testing jruby:9-onbuild
    'override-cmd' [1/1]...passed
testing jruby:1.7
    'utc' [1/9]...passed
    'cve-2014--shellshock' [2/9]...passed
    'no-hard-coded-passwords' [3/9]...passed
    'override-cmd' [4/9]...passed
    'ruby-hello-world' [5/9]...passed
    'ruby-standard-libs' [6/9]...passed
    'ruby-gems' [7/9]...passed
    'ruby-bundler' [8/9]...passed
    'ruby-nonroot' [9/9]...passed
testing jruby:1.7-jdk
    'utc' [1/9]...passed
    'cve-2014--shellshock' [2/9]...passed
    'no-hard-coded-passwords' [3/9]...passed
    'override-cmd' [4/9]...passed
    'ruby-hello-world' [5/9]...passed
    'ruby-standard-libs' [6/9]...passed
    'ruby-gems' [7/9]...passed
    'ruby-bundler' [8/9]...passed
    'ruby-nonroot' [9/9]...passed
testing jruby:1.7-onbuild
    'override-cmd' [1/1]...passed

yosifkit added a commit that referenced this pull request Feb 9, 2016
@yosifkit yosifkit merged commit cc90f62 into docker-library:master Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants