Update socket location for mysql clients #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
reviewed
Feb 25, 2022
template/docker-entrypoint.sh
Outdated
| @@ -379,6 +391,7 @@ _main() { | |||
| mysql_note "MySQL init process done. Ready for start up." | |||
| echo | |||
| fi | |||
| mysql_socket_fix | |||
There was a problem hiding this comment.
For mysqlsh to work in docker-entrypoint-initdb.d scripts too, this needs to happen after docker_init_database_dir too, right? (maybe this becomes else instead of outside the if?)
tianon
approved these changes
Feb 25, 2022
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Feb 28, 2022
Changes: - docker-library/mysql@37981f6: Merge pull request docker-library/mysql#830 from infosiftr/sockets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated
my.cnfis enough formysqlbutmysqlsh --mysqlstill uses the compiled in value, so we need the symlink in the data directory.mysqlsh [user]@localhostworks since it uses the mysqlx port of33060by default.Fixes #829