Prevent mysqld --verbose --help from writing to empty datadir #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se help output to get datadir
|
Change LGTM. On a side note, looks like the test are failing but that is unrelated to this change. |
|
LGTM, tested locally I'm investigating the Travis issue, but it appears to somehow be related to heavy disk activity during the installation of the |
tianon
added a commit
that referenced
this pull request
Jun 12, 2015
Prevent mysqld --verbose --help from writing to empty datadir
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Jun 12, 2015
- `kibana`: add 4.0 back (docker-library/kibana#5) - `mysql`: use `ha` keyserver pool and add `--innodb-read-only` to prevent bugs around `--verbose --help` configuration fetching (docker-library/mysql#78)
RichardScothern
pushed a commit
to RichardScothern/official-images
that referenced
this pull request
Jun 14, 2016
- `kibana`: add 4.0 back (docker-library/kibana#5) - `mysql`: use `ha` keyserver pool and add `--innodb-read-only` to prevent bugs around `--verbose --help` configuration fetching (docker-library/mysql#78)
olegabr
added a commit
to olegabr/mysql
that referenced
this pull request
Aug 1, 2016
same as here: docker-library#78 ``` [ERROR] --initialize specified but the data directory has files in it. Aborting. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From 5.7.6 and on, running mysqld --verbose --help will fully initialize innodb. If datadir is empty and writeable (with the default setup it's not writeable) this will create certain files there, causing the following initialization step to fail.
Using --innodb-read-only prevents this from happening, which should fix issue #69.