Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HEALTHCHECK): add healthcheck instruction in Dockerfile to check mongo status #144

Closed
wants to merge 1 commit into from

Conversation

jerome-lecorvaisier
Copy link

Hey,

Even if everyone knows that mongo is so strong to be unhealth, this feature could be useful.
Maybe there is a best way to check mongo status and/or interval and timeout values could be adjusted but anyway, that's a first try.

Have fun

@tianon
Copy link
Member

tianon commented Mar 13, 2017

I think @yosifkit's comment over in docker-library/cassandra#76 (comment) still accurately summarizes my own feeling about adding an explicit HEALTHCHECK instruction to official images:

I do not feel that generalized healthchecks on the official images are really that useful.

  • users will have their own idea of what is "healthy"
  • it does not actually test that the service is listening to connections outside of localhost (see https://github.com/docker-library/healthcheck for some examples that do more than what's proposed here, including attempting to check whether the service is listening remotely)
    • some of the Official Images even purposely start in a localhost only mode for database initialization and then kill and start the main service with full network availability
  • after upgrading their images, current users will have extra unexpected load on their systems for healthchecks they don't necessarily need/want and may be unaware of

@yosifkit
Copy link
Member

closing based on previous comment.

@yosifkit yosifkit closed this Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants