Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alpine:3.11 #313

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Add alpine:3.11 #313

merged 1 commit into from
Dec 23, 2019

Conversation

sapk
Copy link
Contributor

@sapk sapk commented Dec 20, 2019

It should:

  • add golang:1.12-alpine3.11
  • add golang:1.13-alpine3.11
  • add golang:1.14-rc-alpine3.11
  • remove golang:1.12-alpine3.9
  • remove golang:1.14-rc-alpine3.10
  • set alpine 3.11 as default for alpine base.

Release note: https://alpinelinux.org/posts/Alpine-3.11.0-released.html

- add golang:1.12-alpine3.11
- add golang:1.13-alpine3.11
- add golang:1.14-rc-alpine3.11
- remove golang:1.12-alpine3.9
- remove golang:1.14-rc-alpine3.10
- set alpine 3.11 as default for alpine base.
@thaJeztah
Copy link
Contributor

remove golang:1.12-alpine3.9

Wondering if the alpine 3.9 variant should be kept for existing (non-rc) Go releases

/cc @ncopa @tianon

@sapk sapk mentioned this pull request Dec 20, 2019
@sapk
Copy link
Contributor Author

sapk commented Dec 20, 2019

@thaJeztah Good question.
For details, support for 3.9 end at 2020-11-01so maybe it should be kept.
For removal, I based myself on my previous PR #285

@tianon
Copy link
Member

tianon commented Dec 20, 2019

We've traditionally kept a maximum of two versions here because for Alpine we have to build from source so supporting more than two is a bit heavier.

@tianon tianon merged commit 3f57232 into docker-library:master Dec 23, 2019
@tianon
Copy link
Member

tianon commented Dec 23, 2019

Thanks! 👍

docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Dec 23, 2019
Changes:

- docker-library/golang@3f57232: Merge pull request docker-library/golang#313 from sapk-fork/alpine-3-11
- docker-library/golang@4bf3297: Add alpine:3.11
@sapk sapk deleted the alpine-3-11 branch December 23, 2019 21:12
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Dec 24, 2019
Changes:

- docker-library/golang@7479804: Merge pull request docker-library/golang#314 from infosiftr/armv7
- docker-library/golang@73558b6: Appropriately set GOARM on Alpine's armv7
- docker-library/golang@3f57232: Merge pull request docker-library/golang#313 from sapk-fork/alpine-3-11
- docker-library/golang@4bf3297: Add alpine:3.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants