Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to get architectures of parent images so each gcc image has the same set #36

Merged
merged 2 commits into from
Jun 8, 2017

Conversation

yosifkit
Copy link
Member

@yosifkit yosifkit commented Jun 8, 2017

No hurry. 😉

$ # master branch
$ ./generate-stackbrew-library.sh > gcc-old
$ # archy branch
$ ./generate-stackbrew-library.sh > gcc-new
$ diff gcc-old gcc-new
1c1
< # this file is generated via https://github.com/docker-library/gcc/blob/87dfadb46c2a905abb1bcd383ec15028e4454435/generate-stackbrew-library.sh
---
> # this file is generated via https://github.com/docker-library/gcc/blob/f71e9f9cec20b66bfbab98fd1dc8df78f86647c8/generate-stackbrew-library.sh
8a9
> Architectures: amd64
14a16
> Architectures: amd64
20a23
> Architectures: amd64
26a30
> Architectures: amd64

See also docker-library/buildpack-deps#59.

@tianon
Copy link
Member

tianon commented Jun 8, 2017

Lol, this will be a lot more fun once docker-library/official-images#3041 merges. 😄

@tianon
Copy link
Member

tianon commented Jun 8, 2017

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77447

I think for now, we should explicitly exclude arm32v* with a link to that bug.

https://sources.debian.net/src/gcc-6/6.3.0-18/debian/rules2/#L491-L536 is another good link (where Debian adds a bunch of extra compile flags to ARM builds, like specifying exactly which ARM we're compiling for, and the features of it, which should fix our current build failure there: /usr/include/features.h:364:12: fatal error: sys/cdefs.h: No such file or directory)

@tianon tianon mentioned this pull request Jun 8, 2017
@tianon
Copy link
Member

tianon commented Jun 8, 2017

(filed an issue to track arm32v7 by itself: #37)

@tianon
Copy link
Member

tianon commented Jun 8, 2017

👍 LGTM

@tianon tianon merged commit 6a6a5a9 into docker-library:master Jun 8, 2017
@tianon tianon deleted the archy branch June 8, 2017 19:28
tianon added a commit to infosiftr/stackbrew that referenced this pull request Jun 8, 2017
- `gcc`: multiarch (docker-library/gcc#36)
- `mongo`: explicit `Architectures`
- `openjdk`: multiarch (docker-library/openjdk#121)
- `pypy`: update `pip` installation to match recent Python changes (docker-library/pypy#15)
- `redis`: smaller Debian-based images (redis/docker-library-redis#94), multiarch (redis/docker-library-redis#95)
- `wordpress`: 4.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants