Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark version of the wordpress logo #2509

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LaurentGoderre
Copy link
Member

Not this won't affect the display on Hub until multiple logos are supported in the API and the push script is updated

@tianon
Copy link
Member

tianon commented Dec 2, 2024

Hmm, don't SVGs have ways to accomplish this without a separate file? (ie one SVG that changes based on the viewing mode directly)

We currently have a number of repos that have SVG logos, but we convert them before uploading them to Docker Hub -- do you think that team might be interested in supporting SVGs directly, especially as an alternative to supporting two logo uploads per repository?

@LaurentGoderre
Copy link
Member Author

In theory it is very easy to do this with SVG butbthe complexity is that not all of the logo are in that format and we would need different way to add the logos for the SVG.

@tianon
Copy link
Member

tianon commented Dec 2, 2024

I imagine it's probably easier on the Hub side to update the existing endpoints to accept SVG upload in addition to / in place of PNG and serve them appropriately throughout the platform than it is to implement a second upload flow for a "dark mode" version of the repository logo and add some kind of conditional logic everywhere to use it appropriately (which might be necessary even with the SVG solution, but at least then it's still "just" a single image file/upload, and the conditional logic is more "if SVG" and can be server-side instead of "if dark mode" and have to be dependent on the client-side).

Then the only change here would be that if a given repository has logo.svg, we upload that directly instead of logo[-120].png (with an appropriate content-type)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants