Add YOURLS container documentation #1078
Merged
+79
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
tianon
reviewed
Jul 18, 2018
yourls/content.md
Outdated
|
|
||
| ```console | ||
| $ docker run --name some-%%REPO%% --link some-mysql:mysql -d %%IMAGE%% \ | ||
| -e YOURLS_SITE="https://example.com" |
There was a problem hiding this comment.
This -e needs to be before %%IMAGE%% to work, doesn't it?
yourls/content.md
Outdated
|
|
||
| ```console | ||
| $ docker run --name some-%%REPO%%s -e YOURLS_DB_HOST=10.1.2.3:3306 \ | ||
| -e YOURLS_DB_USER=... -e YOURLS_DB_PASS=... -d %%REPO%% |
There was a problem hiding this comment.
%%REPO%% here at the end should be %%IMAGE%% instead (so the multi-arch descriptions have the right ARCH/yourls image name here)
There was a problem hiding this comment.
You seem right. I took WordPress template as example: https://github.com/docker-library/docs/blob/8117c12eda4829c1c57eb07c02a62028d1e2bfe8/wordpress/content.md
|
(If you don't get to those before @yosifkit reviews docker-library/official-images#3752, we'll likely just take care of them directly to get this merged today.) |
|
@tianon Thanks for the review, I updated to reflect your comments. |
tianon
approved these changes
Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing YOURLS (https://github.com/YOURLS/YOURLS) for creating a new official image.