add workaround for non-static ctr binary in docker 20.10.8
#323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tianon PTAL. It's probably a bit of a dirty workaround 🙈 🙈 🙈 , but it "works", and unblocks us until containerd/containerd#5824 is resolved somehow |
|
SGTM |
thaJeztah
force-pushed
the
docker_20.10.8
branch
from
6743e82 to
5f67167
Compare
thaJeztah
changed the title
ctr binaryctr binary
|
Packages are up on download.docker.com, so updated the URLs; this should be ready for review @tianon |
When compiling containerd's ctr on Go 1.15 or up, the produced binary
is not fully static, causing it to fail on Alpine:
ldd /usr/local/bin/ctr
/lib64/ld-linux-x86-64.so.2 (0x7f1970417000)
This issue is tracked in containerd/containerd#5824.
Until it's fixed, adding `libc6-compat` as a workaround:
https://pkgs.alpinelinux.org/package/edge/main/x86_64/libc6-compat
Note that there's an alternative `gcompat` package, which provides similar
functionality (and also resolves the issue), but unlike `libc6-compat`, that
package is a `community` package, is larger, and has more dependencies:
https://pkgs.alpinelinux.org/package/edge/community/x86_64/gcompat
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
docker_20.10.8
branch
from
5f67167 to
75e26ed
Compare
|
I wonder if this (separately, not a blocker) warrants adding something that invokes |
thaJeztah
changed the title
ctr binaryctr binary in docker 20.10.8
tianon
approved these changes
Aug 4, 2021
| @@ -2,6 +2,10 @@ FROM alpine:{{ .alpine }} | |||
|
|
|||
| RUN apk add --no-cache \ | |||
| ca-certificates \ | |||
| {{ if ["19.03", "19.03-rc", "20.10-rc"] | index(env.version) | not then ( -}} | |||
There was a problem hiding this comment.
Very minor nit that this should probably be env.version == "20.10", but it's harmless and the same either way, and hopefully temporary 😄
There was a problem hiding this comment.
oh! wrote this based on the existing example I found. didn't try other options, but yes, makes sense.
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Aug 4, 2021
Changes: - docker-library/docker@0e65005: Merge pull request docker-library/docker#323 from thaJeztah/docker_20.10.8 - docker-library/docker@75e26ed: Add libc6-compat as workaround for non-static ctr binary - docker-library/docker@83e4de3: Update 20.10 to 20.10.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add libc6-compat as workaround for non-static ctr binary
When compiling containerd's ctr on Go 1.15 or up, the produced binary
is not fully static, causing it to fail on Alpine:
This issue is tracked in containerd/containerd#5824.
Until it's fixed, adding
libc6-compatas a workaround:https://pkgs.alpinelinux.org/package/edge/main/x86_64/libc6-compat
Note that there's an alternative
gcompatpackage, which provides similarfunctionality (and also resolves the issue), but unlike
libc6-compat, thatpackage is a
communitypackage, is larger, and has more dependencies:https://pkgs.alpinelinux.org/package/edge/community/x86_64/gcompat
WIP: test docker 20.10.8 (from staging)
Update the Dockerfile with Docker 20.10.8, which is currently on download-stage.docker.com