[19.03] roll-back libnetwork iptables forward policy change [DESKTOP-1934]

[thaJeztah]

this rolls back the libnetwork bump from 559be42 with 1 commit

The patch made in moby/libnetwork#2450 caused a breaking change in the
networking behaviour, causing Kubernetes installations on Docker Desktop
(and possibly other setups) to fail.

Rolling back this change in the 19.03 branch while we investigate if there
are alternatives.

diff: moby/libnetwork@45c7102...96bcc0d

[thaJeztah]

ping @justincormack @silvin-lubecki @euanh @andrewhsu PTAL

[andrewhsu]

SGTM on green

[justincormack]

Lgtm

…

On Mon, 7 Oct 2019 at 10:10, Arko Dasgupta ***@***.***> wrote: ***@***.**** approved this pull request. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#398>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADVYPDF2RSTMOT2V7A5OKTQNNURNANCNFSM4I6GVYPQ> .

[andrewhsu]

Hmm...just one test failure:

--- FAIL: TestContainerBindMountNonRecursive (2.13s)
    mounts_linux_test.go:261: assertion failed: error is not nil: Error response from daemon: ttrpc: closed: unknown

[thaJeztah]

kicked CI, but if we think it's ok, we can merge

[joeabbey]

Why did this one fail

[2019-10-07T18:45:19.141Z] --- FAIL: TestInspect (12.14s)
[2019-10-07T18:45:19.141Z]     inspect_test.go:23: Creating a new daemon at: /go/src/github.com/docker/docker/bundles/test-integration/TestInspect
[2019-10-07T18:45:19.141Z]     daemon.go:325: [d3ca03e6346e4] waiting for daemon to start
[2019-10-07T18:45:19.141Z]     daemon.go:325: [d3ca03e6346e4] waiting for daemon to start
[2019-10-07T18:45:19.141Z]     daemon.go:353: [d3ca03e6346e4] daemon started
[2019-10-07T18:45:19.141Z]     inspect_test.go:39: timeout hit after 10s: waiting for tasks to enter run state. task failed with error: task: non-zero exit (1)
[2019-10-07T18:45:19.141Z]     daemon.go:461: [d3ca03e6346e4] Stopping daemon
[2019-10-07T18:45:19.141Z]     daemon.go:296: [d3ca03e6346e4] exiting daemon
[2019-10-07T18:45:19.141Z]     daemon.go:448: [d3ca03e6346e4] Daemon stopped
[2019-10-07T18:45:19.141Z] === RUN   TestDockerNetworkConnectAlias

[thaJeztah]

Daemon logs of the daemon for that test:
d3ca03e6346e4.log

[joeabbey]

But.. now DCO check fails? https://ci.docker.com/public/blue/organizations/jenkins/engine/detail/PR-398/5/pipeline

[thaJeztah]

ah, that's probably because it's diffing the wrong diff 😞 need to backport moby#40035 for that

[thaJeztah]

I created an escape hatch for that; let me rebuild with the "skip dco" option set

[thaJeztah]

It's green now; I skipped the DCO check, but the commit is signed-off;

I'll backport moby#40035 to get this to prevent the DCO flakiness

[thaJeztah]

bringing this one in