-
Notifications
You must be signed in to change notification settings - Fork 879
OPS-5907: remove ParallelKey class #961
OPS-5907: remove ParallelKey class #961
Conversation
@@ -26,14 +26,8 @@ | |||
|
|||
""" | |||
|
|||
import gevent.monkey | |||
gevent.monkey.patch_all() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not take the chance to remove gevent patching here - though it seems ludicrous, I'm pretty sure there was a reason for it being duplicated here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. I'll put it back in.
One simple nit, LGTM otherwise. |
I restored the gevent.monkey.patch code, which causes the following flake8 errors:
flake8 generated similar errors before I modified the file. I'll test the code with the restored gevent.monkey.patch (even thought I don't expect any problems from it). |
I tested the code with the restored gevent.monkey.patch with both [AWS_SECURE=false; STORAGE_REDIRECT=true] and [AWS_SECURE=true; STORAGE_REDIRECT=false]. Both worked as expected. Performance looks unchanged. |
In order to make flake/hacking stop complaining here, you can:
LGTM otherwise - merging. |
OPS-5907: remove ParallelKey class
This pull request removes the ParallelKey class as discussed in issue #956. Performance tests on AWS with an m3.medium docker client and different size registry servers (m3.large, m3.xlarge, c3.xlarge) indicate that:
There may be some use cases where ParallelKey helps performance, but I couldn't find them with the test configuration using the m3.medium client.