Store context type in metadata to make retrocompatibility with previous contexts easier (potentially switching back and forth) #200
Conversation
context/store/store.go
Outdated
| // ContextMetadata is represtentation of the data we put in a context | ||
| // metadata | ||
| type ContextMetadata struct { | ||
| Type string `json:",omitempty"` |
There was a problem hiding this comment.
This might provoke the same issue in the future as what we had in the previous CLI. See docker/cli#2572 for the classic CLI fix
…us contexts easier (potentially switching back and forth)
gtardif
force-pushed
the
context_store_type
branch
from
97d4bb1 to
e768268
Compare
| "encoding/json" | ||
| "testing" | ||
|
|
||
| . "github.com/onsi/gomega" |
There was a problem hiding this comment.
nit: We should decide as a team if we want to use gomega or testify/{require,assert}. Not at all urgent but a bit jarring to have two different libraries depending on where we are in the code
There was a problem hiding this comment.
We also have gotest.tools, so there's three now?
There was a problem hiding this comment.
Yes.. gotest.tools doesn't have all the functionality we need. e.g.: Test suites with setup and teardown functions. It also doesn't have something like testify's require which continues testing even if a failure is encountered.
What I did
Related issue
Needed to ensure backward compatibility if users switch back and forth, to avoid loosing the type info.
Also required to ensure context sync between HyperV and WSL2 environments, allowing to use the /docker/cli code to read/write contexts. cc @simonferquel
(not mandatory) A picture of a cute animal, if possible in relation with what you did
