Fix channel number address parser

docbender · Sep 29, 2020 · 6abf418 · 6abf418
1 parent 21dffa1
commit 6abf418
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 7 deletions.
diff --git a/...atic/src/main/java/org/openhab/binding/simatic/internal/handler/simaticBridgeHandler.java b/...atic/src/main/java/org/openhab/binding/simatic/internal/handler/simaticBridgeHandler.java
@@ -250,6 +250,7 @@ public void handleRemoval() {
      */
     public void updateConfig() {
         int stateChannelCount = 0;
+        channelCount = 0;
 
         for (Thing th : getThing().getThings()) {
             var h = ((SimaticGenericHandler) th.getHandler());

diff --git a/...ng.simatic/src/main/java/org/openhab/binding/simatic/internal/simatic/SimaticChannel.java b/...ng.simatic/src/main/java/org/openhab/binding/simatic/internal/simatic/SimaticChannel.java
@@ -109,13 +109,23 @@ public void clear() {
                             address, channelType.getId());
                     return null;
                 }
-                if (matcher.group(1) == null) {
-                    return new SimaticPLCAddress(Integer.parseInt(matcher.group(6)), matcher.group(7),
-                            Integer.parseInt(matcher.group(8)),
-                            matcher.group(9) != null && !matcher.group(9).isEmpty());
+                if (matcher.group(1) != null) {
+                    return new SimaticPLCAddress(matcher.group(2), Integer.parseInt(matcher.group(3)), false);
+                } else if (matcher.group(4) != null) {
+                    return new SimaticPLCAddress(matcher.group(5), Integer.parseInt(matcher.group(6)),
+                            matcher.group(7) != null && !matcher.group(7).isEmpty());
+                } else if (matcher.group(8) != null) {
+                    return new SimaticPLCAddress(Integer.parseInt(matcher.group(9)), matcher.group(10),
+                            Integer.parseInt(matcher.group(11)), false);
+                } else if (matcher.group(12) != null) {
+                    return new SimaticPLCAddress(Integer.parseInt(matcher.group(13)), matcher.group(14),
+                            Integer.parseInt(matcher.group(15)),
+                            matcher.group(16) != null && !matcher.group(16).isEmpty());
                 } else {
-                    return new SimaticPLCAddress(matcher.group(2), Integer.parseInt(matcher.group(3)),
-                            matcher.group(4) != null && !matcher.group(4).isEmpty());
+                    error = String.format(
+                            "Unsupported address '%s' for typeID=%s. Supported types B,W,D. Address example IB10, MW100, DB1.DBD0, DB1.DBD0F",
+                            address, channelType.getId());
+                    return null;
                 }
             case SimaticBindingConstants.CHANNEL_STRING:
                 matcher = stringAddressPattern.matcher(address);

diff --git a/...g.simatic/src/main/java/org/openhab/binding/simatic/internal/simaticBindingConstants.java b/...g.simatic/src/main/java/org/openhab/binding/simatic/internal/simaticBindingConstants.java
@@ -25,7 +25,7 @@
 @NonNullByDefault
 public class SimaticBindingConstants {
 
-    public static final String VERSION = "3.0.0-beta.2";
+    public static final String VERSION = "3.0.0-beta.3";
 
     private static final String BINDING_ID = "simatic";