Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make id unique by fully qualified test name #115

Merged
merged 1 commit into from
May 11, 2023
Merged

fix: make id unique by fully qualified test name #115

merged 1 commit into from
May 11, 2023

Conversation

bianyifan
Copy link
Contributor

@bianyifan bianyifan commented May 11, 2023 •
edited
Loading

When test specs are shared by multiple test methods, TestCase.Id could be duplicated. This change makes TestCase.Id unique by including type name and method name in ID generation.

yufeih
yufeih approved these changes May 11, 2023
View reviewed changes
Copy link
Collaborator

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bianyifan !

@yufeih yufeih merged commit a5fef0b into docascode:main May 11, 2023
@bianyifan bianyifan deleted the fix-test-id branch May 11, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufeih yufeih yufeih approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bianyifan @yufeih