-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test/add test e2e #161
Test/add test e2e #161
Conversation
8df1f02
to
e0a0550
Compare
a014abd
to
17ef8ca
Compare
.github/workflows/main-ci.yml
Outdated
timeout-minutes: 10 | ||
needs: | ||
- build-frontend | ||
if: (!github.event.pull_request.draft) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nécessaire ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ça permet de ne pas lancer la ci si ta PR est en draft. C'est bien quand il y a beaucoup de test et qu'on en est pas encore a review la PR
.github/workflows/main-ci.yml
Outdated
- name: Install dependencies | ||
working-directory: ./client | ||
run: | | ||
npm ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On utilise plutôt pnpm non ?
ça me semble très bien, tu peux aussi t'inspirer de ce qu'on a fait sur Basegun, comme ça on peut aussi avoir le code coverage ! |
b3b8145
to
e267c29
Compare
2b146f0
to
78ecafc
Compare
78ecafc
to
5085751
Compare
No description provided.