Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/add test e2e #161

Closed
wants to merge 3 commits into from
Closed

Test/add test e2e #161

wants to merge 3 commits into from

Conversation

Carolinedanslesnuages
Copy link
Collaborator

No description provided.

@Carolinedanslesnuages Carolinedanslesnuages marked this pull request as draft December 12, 2024 15:58
@Carolinedanslesnuages Carolinedanslesnuages force-pushed the test/add-test-e2e branch 2 times, most recently from 8df1f02 to e0a0550 Compare December 12, 2024 16:25
@Carolinedanslesnuages Carolinedanslesnuages marked this pull request as ready for review December 19, 2024 13:55
@Carolinedanslesnuages Carolinedanslesnuages force-pushed the test/add-test-e2e branch 2 times, most recently from a014abd to 17ef8ca Compare December 19, 2024 14:45
timeout-minutes: 10
needs:
- build-frontend
if: (!github.event.pull_request.draft)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nécessaire ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ça permet de ne pas lancer la ci si ta PR est en draft. C'est bien quand il y a beaucoup de test et qu'on en est pas encore a review la PR

- name: Install dependencies
working-directory: ./client
run: |
npm ci
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On utilise plutôt pnpm non ?

@thomashbrnrd
Copy link
Collaborator

ça me semble très bien, tu peux aussi t'inspirer de ce qu'on a fait sur Basegun, comme ça on peut aussi avoir le code coverage !

@Carolinedanslesnuages Carolinedanslesnuages force-pushed the test/add-test-e2e branch 18 times, most recently from b3b8145 to e267c29 Compare December 20, 2024 11:10
@Carolinedanslesnuages Carolinedanslesnuages linked an issue Dec 20, 2024 that may be closed by this pull request
5 tasks
@Carolinedanslesnuages Carolinedanslesnuages force-pushed the test/add-test-e2e branch 10 times, most recently from 2b146f0 to 78ecafc Compare December 23, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ajouter test E2E Front
2 participants