feat: 📝 Add params in swagger for searchapplications #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Carolinedanslesnuages
commented
Dec 10, 2024
Carolinedanslesnuages
commented
- Rendu le champ label optionnel dans le SearchApplicationDto pour permettre des valeurs vides.
- Modifié la méthode searchApplications du service pour utiliser dynamiquement le paramètre limit au lieu d’une valeur fixe.
- Amélioré la documentation Swagger en utilisant @ApiPropertyOptional pour les champs optionnels et en ajoutant des descriptions détaillées.
- Ajouté la gestion des réponses d’erreur dans le contrôleur pour mieux documenter les cas d’échec.
Carolinedanslesnuages
force-pushed
the
feat/Add-property-for-swagger
branch
from
684fedb to
32047e5
Compare
Carolinedanslesnuages
force-pushed
the
feat/Add-property-for-swagger
branch
from
32047e5 to
b9e2e87
Compare
| description: | ||
| 'Liste des applications correspondant aux critères de recherche.', | ||
| }) | ||
| @ApiResponse({ status: 400, description: 'Requête invalide.' }) |
There was a problem hiding this comment.
Je ne pense pas que ce soit nécessaire de décrire les erreurs 400 et 500, cela revient un peu à dupliquer : https://developer.mozilla.org/en-US/docs/Web/HTTP/Status
Carolinedanslesnuages
force-pushed
the
feat/Add-property-for-swagger
branch
from
b9e2e87 to
39c1270
Compare
thomashbrnrd
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.