Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ♻️ remove isDummyTypology and refactor guideFactice #480

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

nutfdt
Copy link
Collaborator

@nutfdt nutfdt commented May 31, 2024

No description provided.

@nutfdt nutfdt added the javascript Pull requests that update Javascript code label May 31, 2024
@nutfdt nutfdt self-assigned this May 31, 2024
@nutfdt nutfdt requested a review from thomashbrnrd as a code owner May 31, 2024 13:14
@nutfdt nutfdt linked an issue May 31, 2024 that may be closed by this pull request
leihuayi

This comment was marked as duplicate.

Copy link
Contributor

@leihuayi leihuayi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename word "factice" to "dummy" everywhere to keep maximum english

@nutfdt nutfdt force-pushed the remove-isdummytypology branch from b6fa395 to 65452c3 Compare June 3, 2024 09:03
@thomashbrnrd thomashbrnrd force-pushed the remove-isdummytypology branch from 58879ad to f0f316b Compare June 3, 2024 09:44
@nutfdt nutfdt force-pushed the remove-isdummytypology branch from f0f316b to 0bac91a Compare June 3, 2024 11:37
@nutfdt nutfdt requested review from leihuayi and thomashbrnrd June 3, 2024 12:36
@nutfdt nutfdt force-pushed the remove-isdummytypology branch from ddff9ca to e98cacd Compare June 3, 2024 13:37
@nutfdt nutfdt dismissed leihuayi’s stale review June 3, 2024 14:33

modifications faites

@nutfdt nutfdt merged commit e561dc7 into develop Jun 3, 2024
6 checks passed
@nutfdt nutfdt deleted the remove-isdummytypology branch June 3, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove isDummyTypology
3 participants