feat: ✨ handle video in options steps #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nutfdt
force-pushed
the
feat/#185-handle-video-in-options-steps
branch
from
139ef86 to
ac33453
Compare
nutfdt
added a commit
that referenced
this pull request
Oct 10, 2023
* refactor: ♻️ remove swiper component and add page instead * refactor: ♻️ remove swiper component and add page instead * refactor: ♻️ refactoring StartPage * chore: ⬆️ Upgrade dependancies * feat: 🐛 Fix routing * feat: ✨ Add 2 buttons on StartPage * feat: ✨ Add new stepper to securing firearm * style: 🎨 * style: 💄 Move stepper title inline * feat: 💄 Update Basegun baseline * feat: ✨ Add tutorial content to secure a firearm * feat: 🎨 Add new identification guide * WIP identification stepper * fix: 🐛 Fix issues in routing * chore: ⬆️ Upgrade dependancies * refactor: 🎨 Replace OnboardingPage by Swiper * refactor: 🎨 * refactor: ♻️ Refactoring on page result * fix: 🎨 Improve navigation in identificationGuide * style: 💄 Add style on ResultPage * feat: ⚡ WIP : Switch to different routes for each tutorial * add test video to secure a firearm * feat: ✨ Add securing-firearm-util.js file * fix: ✅ Fix tests E2E in securing branch * split securing-firearms-utils.js in 12 specifics files * feat: ⚡ Fix selectAmmo for dummy typologies * WIP * WIP MES * upgrade dependencies * Wip MES * Add new photos and videos in several typologies * Add specific select options for revolver * Change legal category if revolver black powder * Add step 3 options for revolver * Add content and style on accordions title * wip css integration * add minified header on mobile * style: 💄 Add whole logo only on start pages * style: 💄 Add whole logo only on start pages * fix DsfrRadioButton rich image ratio * add accordion design to revolver-1873-fr * add video parts to accordion design * refactor: ♻️ Remove useless code and clean code * refactor: ♻️ Renaming components * refactor: ♻️ Add highlight bold on tutorial texts manipulations * refactor: ♻️ remove useless const identificationTutorial * wip-refacto * refactor: ♻️ improve navigation in guideSecuringFirearms * perf: ♻️ Downsize too big photos * refactoring titles styles * chore: ⬇️ Downgrade Cypress from 13.1.0 to 12.17.4 * refactor: ⚡ Make accordion tutorial only visible for revolver 1873 typology * style: 💄 add new routes names and new icons on securing tutorial * feat: ✨ add a different security message for civilians * fix: 🐛 fix tutorial display for revolver different from 1892 and 1873fr * style: 💄 add new images with focus for securing firearm * style: 💄 add new photos with circle * refactoring titles styles * refactor: ♻️ wip refactor selectOption component * fix: 🐛 fix navigation for revolver typology * refactor: ♻️ Fix refactoring selectOption component * chore: ⬆️ upgrade dependencies * [WIP] test: 🧪 tests/e2e (#176) * chore: 🔧 add start script * refactor: 🔥 remove unused code * chore: 🚨 improve eslint config * test: ✅ add new test to identificate a firearm * test: ✅ add new test to securing firearm * fix: ✅ fix errors and variable name * fix: ✅ triying to fix video loading issue * test: ✅ add new test to identificate firearm fiability * chore: ⬆️ upgrade dependencies in frontend * test: ✅ add new test to identificate revolver typology * test: ✅ add new test to identificate revolver typology * test: ✅ add new test to securing shoulder bolt rifle * test: ✅ add new test to securing old mechanism pistol * test: 🔨 add new commands for tests e2e * test: ✅ update existing tests with new commands * test: ✅ add new test for check if it's FSI or Civilians recommendations * test: ✅ update tests and files * test: ✅ update tests and files --------- Co-authored-by: Nadeige COUTHON <[email protected]> * feat: ✨ handle video in options steps (#187) * feat: ✨ handle video in options steps * style: 💄 updated revolver securing first steps video * style: 💄 updated revolver securing first steps video * style: 💄 update revolver barrel video and instructions * style: 💄 update revolver choice display * style: 💄 updated shotgun videos * test: ✅ skip fiability test --------- Co-authored-by: David Mendy <[email protected]> Co-authored-by: nutfdt <[email protected]>
thomashbrnrd
pushed a commit
that referenced
this pull request
Oct 24, 2023
* refactor: ♻️ remove swiper component and add page instead * refactor: ♻️ remove swiper component and add page instead * refactor: ♻️ refactoring StartPage * chore: ⬆️ Upgrade dependancies * feat: 🐛 Fix routing * feat: ✨ Add 2 buttons on StartPage * feat: ✨ Add new stepper to securing firearm * style: 🎨 * style: 💄 Move stepper title inline * feat: 💄 Update Basegun baseline * feat: ✨ Add tutorial content to secure a firearm * feat: 🎨 Add new identification guide * WIP identification stepper * fix: 🐛 Fix issues in routing * chore: ⬆️ Upgrade dependancies * refactor: 🎨 Replace OnboardingPage by Swiper * refactor: 🎨 * refactor: ♻️ Refactoring on page result * fix: 🎨 Improve navigation in identificationGuide * style: 💄 Add style on ResultPage * feat: ⚡ WIP : Switch to different routes for each tutorial * add test video to secure a firearm * feat: ✨ Add securing-firearm-util.js file * fix: ✅ Fix tests E2E in securing branch * split securing-firearms-utils.js in 12 specifics files * feat: ⚡ Fix selectAmmo for dummy typologies * WIP * WIP MES * upgrade dependencies * Wip MES * Add new photos and videos in several typologies * Add specific select options for revolver * Change legal category if revolver black powder * Add step 3 options for revolver * Add content and style on accordions title * wip css integration * add minified header on mobile * style: 💄 Add whole logo only on start pages * style: 💄 Add whole logo only on start pages * fix DsfrRadioButton rich image ratio * add accordion design to revolver-1873-fr * add video parts to accordion design * refactor: ♻️ Remove useless code and clean code * refactor: ♻️ Renaming components * refactor: ♻️ Add highlight bold on tutorial texts manipulations * refactor: ♻️ remove useless const identificationTutorial * wip-refacto * refactor: ♻️ improve navigation in guideSecuringFirearms * perf: ♻️ Downsize too big photos * refactoring titles styles * chore: ⬇️ Downgrade Cypress from 13.1.0 to 12.17.4 * refactor: ⚡ Make accordion tutorial only visible for revolver 1873 typology * style: 💄 add new routes names and new icons on securing tutorial * feat: ✨ add a different security message for civilians * fix: 🐛 fix tutorial display for revolver different from 1892 and 1873fr * style: 💄 add new images with focus for securing firearm * style: 💄 add new photos with circle * refactoring titles styles * refactor: ♻️ wip refactor selectOption component * fix: 🐛 fix navigation for revolver typology * refactor: ♻️ Fix refactoring selectOption component * chore: ⬆️ upgrade dependencies * [WIP] test: 🧪 tests/e2e (#176) * chore: 🔧 add start script * refactor: 🔥 remove unused code * chore: 🚨 improve eslint config * test: ✅ add new test to identificate a firearm * test: ✅ add new test to securing firearm * fix: ✅ fix errors and variable name * fix: ✅ triying to fix video loading issue * test: ✅ add new test to identificate firearm fiability * chore: ⬆️ upgrade dependencies in frontend * test: ✅ add new test to identificate revolver typology * test: ✅ add new test to identificate revolver typology * test: ✅ add new test to securing shoulder bolt rifle * test: ✅ add new test to securing old mechanism pistol * test: 🔨 add new commands for tests e2e * test: ✅ update existing tests with new commands * test: ✅ add new test for check if it's FSI or Civilians recommendations * test: ✅ update tests and files * test: ✅ update tests and files --------- Co-authored-by: Nadeige COUTHON <[email protected]> * feat: ✨ handle video in options steps (#187) * feat: ✨ handle video in options steps * style: 💄 updated revolver securing first steps video * style: 💄 updated revolver securing first steps video * style: 💄 update revolver barrel video and instructions * style: 💄 update revolver choice display * style: 💄 updated shotgun videos * test: ✅ skip fiability test --------- Co-authored-by: David Mendy <[email protected]> Co-authored-by: nutfdt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #185