Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure HTTP client timeouts #12

Merged
merged 7 commits into from
Apr 19, 2022
Merged

Conversation

kkupreeva
Copy link
Contributor

Description

This PR allows configuring HTTP client timeout in the config file for each target and as a command line flag.

Fixes # (7)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Running existing tests
  • Created new tests

Checklist:

  • My code has been linted (make lint)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have rebased my branch to include the latest changes from master

@ghost
Copy link

ghost commented Apr 16, 2022

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

@dnnrly
Copy link
Owner

dnnrly commented Apr 16, 2022

This looks good so far but at this point on a Satursay night, I'm not in the right state to review it properly. 😵

If I haven't reviewed properly in couple of days then poke me again.

config.go Show resolved Hide resolved
waitfor.go Show resolved Hide resolved
config.go Outdated Show resolved Hide resolved
config.go Outdated Show resolved Hide resolved
@dnnrly
Copy link
Owner

dnnrly commented Apr 18, 2022

I've updated main to allow PR builds to be able to run the check actions. Would you be able to rebase on to main so you can run these checks please.

@dnnrly
Copy link
Owner

dnnrly commented Apr 18, 2022

Overall a very good PR!

@dnnrly dnnrly merged commit 7dbfefd into dnnrly:main Apr 19, 2022
@dnnrly
Copy link
Owner

dnnrly commented Apr 19, 2022

Excellent, thanks for the contribution! I know it's small, but you've just earned another Twitter follower. (Assuming that's OK and you let me know what your handle is.)

@kkupreeva
Copy link
Contributor Author

Thank you for the quick and useful review! 👍
I don't have a Twitter account 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants