-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure HTTP client timeouts #12
Conversation
CodeSee Review Map:Review in an interactive map View more CodeSee Maps Legend |
This looks good so far but at this point on a Satursay night, I'm not in the right state to review it properly. 😵 If I haven't reviewed properly in couple of days then poke me again. |
I've updated |
Overall a very good PR! |
Excellent, thanks for the contribution! I know it's small, but you've just earned another Twitter follower. (Assuming that's OK and you let me know what your handle is.) |
Thank you for the quick and useful review! 👍 |
Description
This PR allows configuring HTTP client timeout in the config file for each target and as a command line flag.
Fixes # (7)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
make lint
)master