X.PagedList.Mvc.Core: Revert behavior for UpdateTargetId #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 01d9633. In [1], behavior for the UpdateTargetId was changed so the "#" symbol is not prepended anymore and one has to add it manually now. However, the very name "UpdateTargetId" indicates that this is an ID and not something else. Similar behavior is found for JavaScript, where a function name containing "Id" implies that the hash symbol is not required. Revert this to the previous behavior (<= 8.4.7), so it can be used without changes coming from any version except 9.1.2. This implements the correct behavior as it implies the provided value is actually an ID. Future alternate solutions as discussed in dncuug#245 might choose different names to accept arbitrary elements as argument (e.g. UpdateTarget to accept IDs, classes, etc.). Note that examples never got updated anyway (and thus no need to revert them). [1] 01d9633 ("Close dncuug#221") Fixes: dncuug#245
adschmu
force-pushed
the
pr/revert-ajax-update
branch
from
f47f442 to
f3745d8
Compare
a-gubskiy
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 01d9633.
In [1], behavior for the UpdateTargetId was changed so the "#" symbol is not prepended anymore and one has to add it manually now. However, the very name "UpdateTargetId" indicates that this is an ID and not something else. Similar behavior is found for JavaScript, where a function name containing "Id" implies that the hash symbol is not required.
Revert this to the previous behavior (<= 8.4.7), so it can be used without changes coming from any version except 9.1.2. This implements the correct behavior as it implies the provided value is actually an ID.
Future alternate solutions as discussed in #245 might choose different names to accept arbitrary elements as argument (e.g. UpdateTarget to accept IDs, classes, etc.).
Note that examples never got updated anyway (and thus no need to revert them).
[1] 01d9633 ("Close #221")
Fixes: #245