Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Upload): add new Upload component #1581

Merged
merged 21 commits into from
Oct 13, 2022
Merged

feat(Upload): add new Upload component #1581

merged 21 commits into from
Oct 13, 2022

Conversation

AadneRo
Copy link
Contributor

@AadneRo AadneRo commented Sep 26, 2022

Add Upload component mvp.

Still missing some features:

  • Drag and drop to upload file

I also removed the validation, we can add validation later if needed

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 26, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f553dc8:

Sandbox Source
eufemia-starter Configuration

@gatsby-cloud
Copy link

gatsby-cloud bot commented Sep 26, 2022 •
edited
Loading

✅ DNB Eufemia Portal deploy preview ready

@tujoworker tujoworker changed the title feat(Upload) feat(Upload): add new Upload component Sep 26, 2022
langz
langz reviewed Sep 26, 2022
View reviewed changes
packages/dnb-eufemia/src/components/upload/UploadFileListCell.tsx Outdated
}
return (
<Icon
icon={images[iconFileType]}
Copy link
Contributor

@langz langz Sep 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this feature, displaying the icon for a given file extension 💯

I don't want to overcomplicate things, but for instance ppt(powerpoint) probably have a lot of file extensions, like on MacBook when creating a ppt it's probably using .pptx file extension, etc.
So when uploading a file with .pptx as file extension, I assume that we will not see the great ppt icon 🤔

We can probably never "support icons for all crazy variants of file extensions", like many of the file extensions listed here, but I 'm not sure where to draw the line 🖌️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have sent the link to your thoughts to UX Mats 👍

@langz

This comment was marked as resolved.

Sign in to view
@langz langz mentioned this pull request Sep 27, 2022
Merged
@langz

This comment was marked as resolved.

Sign in to view
@AadneRo

This comment was marked as resolved.

Sign in to view
@AadneRo AadneRo force-pushed the feat/upload-component branch 2 times, most recently from 749b85e to 2e18e1a Compare September 28, 2022 10:29
@tujoworker
Ensure css idiomatic ordering (declaration)
2a625e6 
Ref.: https://github.com/necolas/idiomatic-css#declaration-order
@tujoworker
Add css dependencies
96d203f
@tujoworker
Import icons with "as" for less duplication
4090afe
@tujoworker
Remove unnecessary div
354498a
@tujoworker
Fix lists spacing
648da2e
@tujoworker
Move less important elements down in the DOM tree
9acfb7b
@tujoworker
Ensure the outline (SVG stroke element) is not select able with mouse…
2cc8e60 
… cursor
@tujoworker
Ensure hidden input file element takes no space in layout
afc156d
@tujoworker
Correct UX spacing
d19712f
@tujoworker
Update snapshots
6c3f153
@tujoworker
Fix failing axe test by linking input labels
23e0927
@tujoworker
Set correct spacing
b46c0ba
@tujoworker
Set focus on button when file gets deleted
0fd0c15
@tujoworker
Spacing correction after PR #1626
4b10358
@tujoworker
Add mocked example files
e851eef
@tujoworker
Animate canvas
5949322
@tujoworker
Update visual snapshots
d1faa7b
@tujoworker tujoworker self-requested a review October 12, 2022 13:01
tujoworker
tujoworker approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Awesome work 🕺

@AadneRo AadneRo merged commit 3304347 into main Oct 13, 2022
@AadneRo AadneRo deleted the feat/upload-component branch October 13, 2022 05:57
@tujoworker
Copy link
Member

Related PRs #1643 #1647 #1645 #1648 #1649

tujoworker pushed a commit that referenced this pull request Oct 23, 2022
@semantic-release-bot
chore(release): 9.33.0 [skip ci]
06585c7 
# [9.33.0](v9.32.1...v9.33.0) (2022-10-23)

### Bug Fixes

* **Accordion:** replace internal animation with HeightAnimation component ([#1619](#1619)) ([2cb2d48](2cb2d48))
* **Dl:** ensure correct spacing ([#1626](#1626)) ([5330e6d](5330e6d))
* **Dl:** remove span as direct sibling for horizontal direction ([#1625](#1625)) ([6845219](6845219))
* **Drawer:** ensure ScrollView is used for scrollable content ([#1632](#1632)) ([fea2358](fea2358))
* **DrawerList:** fix auto sizing when used in Drawer component ([#1634](#1634)) ([f19d58b](f19d58b)), closes [#1632](#1632) [#1633](#1633) [#1631](#1631)
* **DrawerList:** reset "enable_body_lock" handlers after closing ([#1629](#1629)) ([1a90c72](1a90c72))
* **Drawer:** make spacing of header and nav robust ([#1641](#1641)) ([5454ded](5454ded))
* **FormStatus:** fix stretch when used in Dropdown and Autocomplete ([#1618](#1618)) ([a961feb](a961feb))
* **gatsby-plugin-eufemia-theme-handler:** support Gatsby > v4.24 ([#1623](#1623)) ([34d0f6c](34d0f6c))
* **Icon:** fix override of data-testid property when provided ([#1637](#1637)) ([d335a14](d335a14))
* **Pagination:** fix locale support ([#1651](#1651)) ([01b93ce](01b93ce))
* **Section:** make style_type property accept any string ([#1636](#1636)) ([9e51565](9e51565))
* **Section:** rename AllSectionProps to SectionAllProps ([#1640](#1640)) ([23de874](23de874))
* **Space:** rewrite Space component to TypeScript ([#1644](#1644)) ([c59f732](c59f732))
* **Tooltip:** ensure timers cleanup on unmount ([#1642](#1642)) ([6dd4b7b](6dd4b7b))

### Features

* **DrawerList:** animate max-height when changed during scrolling ([#1631](#1631)) ([cf302f7](cf302f7))
* **DrawerList:** animate position when used inside dnb-scroll-view ([#1633](#1633)) ([7ed9550](7ed9550))
* **HeightAnimation:** add showOverflow property ([#1627](#1627)) ([a9bbce4](a9bbce4))
* **HeightAnimation:** make the view open by default ([#1646](#1646)) ([32aa0eb](32aa0eb))
* **icons:** hierarchy, layout_card and unlock ([#1654](#1654)) ([d8d37ba](d8d37ba))
* **Upload:** add new Upload component ([#1581](#1581)) ([3304347](3304347)), closes [#1626](#1626)
@tujoworker
Copy link
Member

🎉 This PR is included in version 9.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tujoworker tujoworker tujoworker approved these changes

@langz langz langz approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AadneRo @langz @tujoworker