Add option to matcher to ignore headers #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new matcher, which is more strict now, is breaking tests where some of the headers are skipped (like secrets) or change on each request (like tracing spans). The cassete already supports the User-Agentt, and the Authorization has also been added but not released yet. In order to make it more generic and usable for people, I've added a more generic implementation of these options, which will allow us to define which headers we really want to ignore. Signed-off-by: ivangonzalezacuna <[email protected]>
ivangonzalezacuna
force-pushed
the
matcher-ignore-headers-generic
branch
from
6f56979 to
81ddc8a
Compare
ivangonzalezacuna
changed the title
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## v4 #104 +/- ##
==========================================
+ Coverage 52.40% 52.50% +0.09%
==========================================
Files 4 4
Lines 498 499 +1
==========================================
+ Hits 261 262 +1
Misses 217 217
Partials 20 20 ☔ View full report in Codecov by Sentry. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new matcher, which is more strict now, is breaking tests where some of the headers are skipped (like secrets) or change on each request (like tracing spans). The cassete already supports the User-Agentt, and the Authorization has also been added but not released yet.
In order to make it more generic and usable for people, I've added a more generic implementation of these options, which will allow us to define which headers we really want to ignore.