Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API phpunit9 support #56

Merged
merged 1 commit into from
Nov 10, 2021
Merged

API phpunit9 support #56

merged 1 commit into from
Nov 10, 2021

Conversation

emteknetnz
Copy link
Collaborator

@emteknetnz emteknetnz marked this pull request as draft October 12, 2021 21:45
@emteknetnz emteknetnz mentioned this pull request Oct 12, 2021
Closed
93 tasks
@emteknetnz emteknetnz force-pushed the pulls/3/sapphire-test-nine branch 2 times, most recently from 7b2eee6 to c26e5e4 Compare October 22, 2021 01:03
@emteknetnz emteknetnz marked this pull request as ready for review October 22, 2021 01:04
@emteknetnz emteknetnz force-pushed the pulls/3/sapphire-test-nine branch from c26e5e4 to 0f486eb Compare October 22, 2021 01:08
@emteknetnz emteknetnz marked this pull request as draft October 22, 2021 01:12
@emteknetnz emteknetnz force-pushed the pulls/3/sapphire-test-nine branch from 0f486eb to d9d1625 Compare October 22, 2021 09:09
maxime-rainville
maxime-rainville requested changes Nov 1, 2021
View reviewed changes
Copy link
Collaborator

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's outstanding work on this one.

@emteknetnz emteknetnz force-pushed the pulls/3/sapphire-test-nine branch 2 times, most recently from e76e207 to 06b11fc Compare November 3, 2021 23:23
@emteknetnz emteknetnz marked this pull request as ready for review November 3, 2021 23:24
@emteknetnz emteknetnz force-pushed the pulls/3/sapphire-test-nine branch 6 times, most recently from 2d4919c to aee837c Compare November 4, 2021 03:08
@emteknetnz emteknetnz marked this pull request as draft November 4, 2021 03:24
@emteknetnz emteknetnz marked this pull request as ready for review November 5, 2021 01:04
maxime-rainville
maxime-rainville approved these changes Nov 8, 2021
View reviewed changes
Copy link
Collaborator

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... builds are failing however. I just re-triggered them

@emteknetnz
Copy link
Collaborator Author

@maxime-rainville fixing broken builds requires requires tagging a new minor of silverstripe/gridfieldextensions which has framework ^4.10 as a requirement, so we should probably merge this with broken build

@emteknetnz emteknetnz force-pushed the pulls/3/sapphire-test-nine branch 2 times, most recently from e221a0b to 68feb56 Compare November 10, 2021 03:33
@emteknetnz emteknetnz force-pushed the pulls/3/sapphire-test-nine branch from 68feb56 to 55576e0 Compare November 10, 2021 03:34
@maxime-rainville maxime-rainville merged commit e2409b2 into dnadesign:3 Nov 10, 2021
@maxime-rainville maxime-rainville deleted the pulls/3/sapphire-test-nine branch November 10, 2021 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @maxime-rainville