Major update to provide compatibility with latest version of elemental

[madmatt]

• Updates to provide compatibility with silverstripe-elemental
• Includes extension to make the module work out of the box

[madmatt]

Hey @pitchandtone, any chance of a review of this?

On this branch, the module now works with the latest ^1 of dnadesign/silverstripe-elemental, and includes code to ensure that the module creates skeleton records on creation of a new page type without needing any project-specific code.

Thanks!

[pitchandtone]

My only concern is this comment "Each page type can be assigned only one {@link Skeleton} object". That's not what I originally had in mind and I suspect will mean that there's some odd coupling between page types and skeletons (blank page types in order to allow another skeleton to be created)

We had imagined a page type could have 2-3 distinct skeletons to choose from, to maintain diversity in the page outcomes. Elemental is trying to maintain rich diverse content rather than locking every page down into a template. Having a 1-1 relationship seems like we're back to a page template approach, rather than something between that and "create anything in any order"

[madmatt]

Ah okay, I hadn't realised that. The original code didn't have any way of referencing to a page (I assume this was done in project code maybe) - was there any plans for how this might work?

I'll see what I can do with this, it's likely to involve injecting JS into CMSPageAddController.

[pitchandtone]

Yeah we hadn’t got that far either. I was thinking we’d detect that there was a skeleton present in get CMSfields (and no elements already tied to it) so then would give a drop down (or similar) instead.

…

Sent from my iPhone

On 7/07/2018, at 10:30 PM, Matt Peel ***@***.***> wrote: Ah okay, I hadn't realised that. The original code didn't have any way of referencing to a page (I assume this was done in project code maybe) - was there any plans for how this might work? I'll see what I can do with this, it's likely to involve injecting JS into CMSPageAddController. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[madmatt]

Ah ok - so adding a custom gridfield action & dropdown that appears if there are no elements attached to a page, allowing users to pick from a list of skeletons? That makes sense, I'll look into doing that :)