Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message/reason for bulkblocks2 API when data already exists in DB #92

Closed
vkuznet opened this issue Feb 25, 2023 · 0 comments
Closed

Fix error message/reason for bulkblocks2 API when data already exists in DB #92

vkuznet opened this issue Feb 25, 2023 · 0 comments
Assignees
@d-ylee
Labels
bug unit test

Comments

@vkuznet
Copy link
Contributor

vkuznet commented Feb 25, 2023

In this commit d0643ba I tried to fix error message since it hides the actual one, but it broke unit tests see this build failure https://github.com/dmwm/dbs2go/actions/runs/4271722647. I reverted the change in this commit 2a7fa9a but I suggest to apply original change and properly fix unit tests.
d-ylee added a commit to d-ylee/dbs2go that referenced this issue Feb 27, 2023
@d-ylee
Fix for Issue dmwm#92
a1f83de 
Fix error message in bulkblocks2 to show actual error message
Fix integration test to pass with the new change
d-ylee added a commit that referenced this issue Feb 28, 2023
@d-ylee
Merge pull request #93 from d-ylee/bugfix-92-fix_unit_tests
928dc25 
Fix for Issue #92
@d-ylee d-ylee closed this as completed Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d-ylee d-ylee

Labels
bug unit test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vkuznet @d-ylee