Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with invalid blocks in WMBS for Dataset start policy #11838

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

amaltaro
Copy link
Contributor

@amaltaro amaltaro commented Dec 22, 2023

Fixes #11822

Status

not-tested

Description

This PR fixes work acquisition from Local WorkQueue into WMBS in the case of an invalid block (a block with only invalid files). This fix applies to workflows with Dataset starting policy, i.e., workflows with a single workqueue element where the actual input is a dataset (instead of the usual block).

In addition, a performance improvement is provided to the listFilesInBlock DBSReader wrapper API, such that we don't try to resolve the lumis in a block with only invalid files.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

None

External dependencies / deployment changes

None

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 1 new failures
    • 1 tests no longer failing
    • 1 changes in unstable tests
  • Python3 Pylint check: failed
    • 2 warnings and errors that must be fixed
    • 10 warnings
    • 147 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 6 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14744/artifact/artifacts/PullRequestReport.html

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 tests no longer failing
    • 1 changes in unstable tests
  • Python3 Pylint check: failed
    • 2 warnings and errors that must be fixed
    • 10 warnings
    • 147 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 6 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14746/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor Author

After some checks, I applied this patch to submit7 and I confirm it works as expected.

I also think that we should patch all the other agents with this PR to ensure that there are no such workflows stuck in the agents.

@amaltaro amaltaro merged commit 1546d41 into dmwm:master Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WMAgent fails to acquire work LQ -> WMBS for Dataset policy with invalid block
3 participants