-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing static dependencies for wmagent package #11586
Fix missing static dependencies for wmagent package #11586
Conversation
Jenkins results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@todor-ivanov please see my comments inline.
Add only needed couchaps
aee700c
to
433112d
Compare
hi @amaltaro I just changed to the reduced set of BTW:
Do you confirm, we do not need them for |
Jenkins results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@todor-ivanov I think we should remove the extra WebTools static package that you added here. Other than that, it's looking good to me now.
I also double checked the design documents and we do not need those 3 above, that you listed from the t0-agent package. I actually think not even the T0 Agent need that, but let's leave that for another occasion.
For the record, the issue this PR is supposed to fix is still sitting in the ToDo status. Please do make sure to set them to "In Progress" whenever you start working on them. |
Fixes #11583
Status
ready
Description
With the current PR we add some missing static dependencies for the
wmagent
package, which are crucial for the deployment throughpypi
or locally.Is it backward compatible (if not, which system it affects?)
YES
Related PRs
None
External dependencies / deployment changes
None