Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multirequest API to encode input parameters and properly handle gzip'ed content #11404

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

vkuznet
Copy link
Contributor

@vkuznet vkuznet commented Dec 16, 2022

Fixes #11403

Status

ready

Description

Provided optional encode input parameter to the API and call decompress function to handle gzip'ed HTTP response from the server

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

External dependencies / deployment changes

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 2 changes in unstable tests
  • Python3 Pylint check: failed
    • 1 warnings and errors that must be fixed
    • 1 warnings
    • 72 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 24 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13844/artifact/artifacts/PullRequestReport.html

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 tests no longer failing
    • 1 tests added
    • 1 changes in unstable tests
  • Python3 Pylint check: failed
    • 3 warnings and errors that must be fixed
    • 6 warnings
    • 92 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 38 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13848/artifact/artifacts/PullRequestReport.html

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 tests added
    • 3 changes in unstable tests
  • Python3 Pylint check: failed
    • 3 warnings and errors that must be fixed
    • 6 warnings
    • 92 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 39 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13851/artifact/artifacts/PullRequestReport.html

@vkuznet vkuznet requested a review from amaltaro December 20, 2022 13:05
Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Valentin. It looks good to me.

@amaltaro amaltaro removed the BUG label Dec 20, 2022
@amaltaro amaltaro merged commit fb39cd4 into dmwm:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix multirequest API in pycurl_manager to support parameters encoding and properly handle gzip responses
3 participants