Remove threadlocal parameter for SQLAlchemy as it is deprecated in new release #11257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins results:
|
|
test this please |
|
Jenkins results:
|
amaltaro
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
Thanks Valentin. I think this change will be transparent for us because we were actually not using it with SQLAlchemy 1.3.3.
FYI @belforte @mapellidario in case you use this strategy attribute in the CRAB systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11205
Status
not-tested
Description
Remove threadlocal parameter as it is deprecated in new SQLAlchemy version
Is it backward compatible (if not, which system it affects?)
MAYBE
Related PRs
#11256
External dependencies / deployment changes