Explicitly create proxies with 2048 bits #11008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested in submit8 at FNAL |
|
Jenkins results:
|
todor-ivanov
approved these changes
Feb 23, 2022
|
@amaltaro what the point of making request review if you merge issue without waiting for review? |
|
@vkuznet this is exactly what I have been trying to discuss with you and Todor. Depending on the PR, I would say that one review is good enough and there is no need to wait for a second review. It also speeds up the review process, in case one of the reviewers is busy with other activities. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11005
Complement to #11006
Status
ready
Description
Ensure that proxies created in the WMAgent nodes are made with 2048 bits in key.
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
#11006
External dependencies / deployment changes
None