Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update diagrams and contribution documentation for end of support for Py2 #10968

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

amaltaro
Copy link
Contributor

@amaltaro amaltaro commented Jan 31, 2022

Fixes #10954

Status

ready

Description

Summary of changes is:

  • update jenkins CI diagrams
  • upgrade contribution guidelines
    as WMCore no longer supports python2

Is it backward compatible (if not, which system it affects?)

NO

Related PRs

None

External dependencies / deployment changes

Requires these Docker repo changes: dmwm/Docker#130 and dmwm/Docker#131
A couple of wikis also need to be updated

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 3 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/12741/artifact/artifacts/PullRequestReport.html

Copy link
Contributor

@todor-ivanov todor-ivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @amaltaro Thanks

@amaltaro
Copy link
Contributor Author

Thank you for the review, Todor and Valentin.

@amaltaro amaltaro merged commit e8ba51a into dmwm:master Jan 31, 2022
@amaltaro
Copy link
Contributor Author

amaltaro commented Feb 4, 2022

For completeness, starting today we also no longer build the python2-based WMCore docker image:
dmwm/Docker#131

since we started introducing dependencies that do/might not work in our python2 stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jenkins: remove Python2 pylint and unit tests from our CI setup
4 participants