Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leading ../../ from logArchive tarballs #10868

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

amaltaro
Copy link
Contributor

@amaltaro amaltaro commented Oct 13, 2021

Fixes #10867

Status

ready

Description

The arcname option allow us to specify an alternative name for the file in the tarball archive. It turns out we were removing only part of the initial path, instead of removing the ../../ as well.

With this change, files inside the tarball should all be set as a top level/directory.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

None

External dependencies / deployment changes

None

@cmsdmwmbot
Copy link

Jenkins results:

  • Python2 Unit tests: succeeded
  • Python3 Unit tests: succeeded
    • 2 changes in unstable tests
  • Python2 Pylint check: failed
    • 3 warnings and errors that must be fixed
    • 1 warnings
    • 13 comments to review
  • Python3 Pylint check: failed
    • 5 warnings and errors that must be fixed
    • 1 warnings
    • 8 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 3 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/12516/artifact/artifacts/PullRequestReport.html

@amaltaro amaltaro requested a review from todor-ivanov October 13, 2021 08:19
@amaltaro
Copy link
Contributor Author

Haaa, and this fixes the problem. New tarball files created with this patch look like:

_condor_stderr
job/WMTaskSpace/cmsRun1/cmsRun1-stderr.log
job/WMTaskSpace/cmsRun1/PSet.py
job/WMTaskSpace/cmsRun1/Report.pkl
job/WMTaskSpace/cmsRun1/FrameworkJobReport.xml
job/WMTaskSpace/cmsRun1/PSet.pkl
job/WMTaskSpace/cmsRun1/cmsRun1-stdout.log
job/WMTaskSpace/stageOut1/Report.pkl
_condor_stdout
wmagentJob.log

@amaltaro
Copy link
Contributor Author

Sorry for rushing with this, but I want to put it in a new patch release still this morning. Feedback is welcome at any time.

@amaltaro amaltaro merged commit 3ff3441 into dmwm:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LogArchive tarball files are created with relative paths
2 participants