Check data-type of fileLumisList

[vkuznet]

In order to extract element from the dict we need to ensure that provided object is indeed a dict data-type. This PR provides this fix for issue dmwm/CRABServer#7378

[vkuznet]

@amaltaro , @mapellidario please review the change I applied to dbsClient to check data type of the object. If you'll sign off this change I'll push it forward and create new dbsClient tag and upload it to PyPi

[amaltaro]

It's hard to review it when you do not know the expected data structure, but I managed to find a dump from 2019, where we can see that this file_lumi_list is supposed to be a list of dictionaries:
https://amaltaro.web.cern.ch/amaltaro/forYuyi/dbsuploader_block.json

I am reviewing your changes now.

[mapellidario]

This looks correct to me. Thanks Valentin for providing the fix promptly! :)

[amaltaro]

Valentin, these changes look good to me. But I suggested possible improvements to the code which is up to you to decide.

Before you make a new release, maybe @mapellidario could patch TaskPublisher - if possible - and test your final changes here before pushing this all the way upstream/services.

[amaltaro]

Now that we know it's a list of dictionaries, I think you could replace most of this code with something safer, e.g.:

flDict = next(iter(fileLumiList), {})
if flDict.get('event_count') is None:
    frst = False

It might be better to rename frst to hasEventCount, or something like that as well.

[mapellidario]

Sure, we can test this in testbed before merging

[vkuznet]

@amaltaro I think we should keep code as is (with changes I provided) as it suppose to work with both DBS server implementations. As we gradually move from one to another I doubt it would be wise to change code to satisfy one server implementation details as we may (even with a small probability) to rollback DBS server and it would be harder to go back with changes. Therefore are some parts which will need clean-up but this step was post-poned until we perform full migration to new implementation.

[vkuznet]

Dario, I'm awaiting your word before merging. Please let me know if you test it on cmsweb-testbed. Thanks, Valentin.

…

On 0, Dario Mapelli ***@***.***> wrote: Sure, we can test this in testbed before merging — Reply to this email directly, [1]view it on GitHub, or [2]unsubscribe. You are receiving this because you authored the thread. Message ID: ***@***.***> References 1. #73 (comment) 2. https://github.com/notifications/unsubscribe-auth/AAA6RUT225DUM6ATYAXH3OTV3DUR3ANCNFSM57XBK45A

[mapellidario]

While having a better look, I noticed that in your changes you sometimes use fileLumiList and fileLumisList.

Assuming that it is a typo, I changed the code to only use fileLumiList and it works smoothly. thanks Valentin!

[vkuznet]

@mapellidario, thanks for spotting a typo. I fixed it now and will proceed with release.