Remove rewritePrefix #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Releases configured with `"esy.release.rewritePrefix": true` cannot be installed into deep filesystem locations (the limit is around 108 characters).
|
I think it is not required for deps, because we are not linking it with esy in runtime, just providing prebuilt binary files |
dmtrKovalenko
approved these changes
Apr 13, 2021
|
I just tested and reproduced the issue on my Mac. Can confirm, that this will fix it. |
dmtrKovalenko
added a commit
that referenced
this pull request
May 22, 2021
* Add basic antialiasing support * Remove cache * Update tests / add tests * Add antialiasing flag * fix: remove rewritePrefix (#30) Releases configured with `"esy.release.rewritePrefix": true` cannot be installed into deep filesystem locations (the limit is around 108 characters). * Clip antialiasing check to correct dimensions * feat: Return diffCount and diffPercentage in nodejs bindings (#32) * Implement parsing results output for node bindings * Update ts typings * Use pattern matching over union Co-authored-by: Torben Ewert <[email protected]> * Better error message Co-authored-by: Torben Ewert <[email protected]> * Better error handling * Add more tests and format package.json Co-authored-by: Torben Ewert <[email protected]> * Bump version * Update ts * chore: Split code into multiple opam packages (#28) (#31) * Split into multiple opam files * generate packages with dune-project * set "use_standard_c_and_cxx_flags" to false * fix public name of bin * Add opam release github action * ci: checkout project sources before releasing * ci: fetch tags * Add synopsis * Setup user and token * Remove --dry-run * feat: Return diffCount and diffPercentage in nodejs bindings (#32) * Implement parsing results output for node bindings * Update ts typings * Use pattern matching over union Co-authored-by: Torben Ewert <[email protected]> * Better error message Co-authored-by: Torben Ewert <[email protected]> * Better error handling * Add more tests and format package.json Co-authored-by: Torben Ewert <[email protected]> * Bump version * Update ts * Split into multiple opam files * generate packages with dune-project * set "use_standard_c_and_cxx_flags" to false * fix public name of bin * Add opam release github action * ci: checkout project sources before releasing * ci: fetch tags * Add synopsis * Setup user and token * Remove --dry-run * ci: Update token location * ci: try cloning opam repo * Delete release-opam.yml investigate automatic releases on a separate branch Co-authored-by: Dmitriy Kovalenko <[email protected]> * Add basic antialiasing support * Remove cache * Update tests / add tests * Add antialiasing flag * Clip antialiasing check to correct dimensions * Fix tests * Make bigarray-first IO version * WIP: add comparing debuggers * Commit test file * Fix compilation * Implement flat bigarray based architecture for antialsing * Fix antialiasing with --diff-mask * More precise type checking for rowPointers fields * switch to 32bit bigarray Co-authored-by: Dmitriy Kovalenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
Releases configured with
"esy.release.rewritePrefix": truecannot be installed into deep filesystem locations (the limit is around 108 characters).@dmtrKovalenko Do you know, if we need this for
esy-libpngoresy-zlib?