Feature/restore reply to and validation #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- re-add the ability to set Reply-To Mail Header from reply_to property json data - add email validation for mail attributes in template model rules and before sending email
…urn-Path and reply-to from schema
…d of throwing a forbidden exception
eluhr
requested changes
Feb 15, 2023
| public function safeUp() | ||
| { | ||
|
|
||
| $this->addColumn('app_dmstr_contact_template','return_path', $this->string()->null()->defaultValue(null)->after('to_email')); |
There was a problem hiding this comment.
Please use {{%dmstr_contact_template}} instead of specifying the prefix directly. This could lead to potential side-effects
There was a problem hiding this comment.
Good point, i've just copied the "wrong" existing migration: https://github.com/dmstr/yii2-contact-module/blob/master/src/migrations/m201012_141325_alter_app_dmstr_contact_template_table.php
;-)
| public function safeUp() | ||
| { | ||
|
|
||
| $this->addColumn('app_dmstr_contact_template','reply_to_schema_property', $this->string()->null()->defaultValue(null)->after('return_path')); |
There was a problem hiding this comment.
Please use {{%dmstr_contact_template}} instead of specifying the prefix directly. This could lead to potential side-effects
src/views/default/done-expired.php
Outdated
|
|
||
| <div class="container text-center"> | ||
| <div class="row"> | ||
| <div class=" col-xs-12 alert alert-success"> |
There was a problem hiding this comment.
Please use an extra div for the alert. Horizontal padding could lead to shifting layout.
eluhr
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
reply_to_emailwas added to the template, which - if set - is used as a "fixed" reply-to for all sended mails. This can be useful, but is not a generic solution to set the reply-to header.This PR:
reply_to_emailaddress - if set - has priority.As we need these "features" also in "older" projects, this PR should be merged in the
release/2.0.xbranch first, and must then be ported to the3.*andmasterbranches.