Bump chrono version to remove outdated time dependency
#280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 23, 2022
|
Ping @dmolokanov, please take a look. |
Porges
added a commit
to microsoft/onefuzz
that referenced
this pull request
Sep 7, 2022
Closes #1366 and incidentally closes #1266. Requires using a not-yet-merged modification to the latest version of `appinsights-rs` to remove the `time` feature from the `chrono` dependency (dmolokanov/appinsights-rs#280). There are changes to use the new (tokio-based) version of `appinsights-rs`, e.g., made `set_appinsights_clients` async to ensure it is always called from an async context, since the constructor for appinsights now invokes `Tokio::spawn`.
|
Closing in favor of #289. Thanks for contribution! |
MichaelMatschiner
added a commit
to MichaelMatschiner/onefuzz
that referenced
this pull request
Dec 26, 2022
Closes #1366 and incidentally closes #1266. Requires using a not-yet-merged modification to the latest version of `appinsights-rs` to remove the `time` feature from the `chrono` dependency (dmolokanov/appinsights-rs#280). There are changes to use the new (tokio-based) version of `appinsights-rs`, e.g., made `set_appinsights_clients` async to ensure it is always called from an async context, since the constructor for appinsights now invokes `Tokio::spawn`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chrono≥ 0.4.20 has the ability to remove the problematictimedependency. Bump it to enable this and remove thetimedependency.This fixes #235.
I also bumped some other versions in the lock files to get rid of other
cargo auditfailures when developing locally, but these don't have downstream effects.