Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Destruct dmlc::Error objects before long jumps #9916

Merged
merged 1 commit into from
Dec 26, 2023
Merged

[R] Destruct dmlc::Error objects before long jumps #9916

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions R-package/src/xgboost_R.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,15 +161,13 @@ object, need to be destructed before triggering the R error.
In order to preserve the error message, it gets copied to a temporary
buffer, and the R error section is reached through a 'goto' statement
that bypasses usual function control flow. */
char cpp_ex_msg[256];
char cpp_ex_msg[512];
/*!
* \brief macro to annotate end of api
*/
#define R_API_END() \
} catch(dmlc::Error& e) { \
Rf_error("%s", e.what()); \
} catch(std::exception &e) { \
std::strncpy(cpp_ex_msg, e.what(), 256); \
std::strncpy(cpp_ex_msg, e.what(), 512); \
goto throw_cpp_ex_as_R_err; \
} \
if (false) { \
Expand Down
Loading