Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build for AppleClang 11 #9684

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Fix build for AppleClang 11 #9684

merged 2 commits into from
Oct 18, 2023

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Oct 17, 2023

@hcho3 hcho3 changed the title Fix 2.0.0 Fix build for AppleClang 11 Oct 17, 2023
@hcho3 hcho3 requested a review from trivialfis October 17, 2023 23:06
@hcho3 hcho3 mentioned this pull request Oct 17, 2023
Closed
hcho3
hcho3 commented Oct 17, 2023
View reviewed changes
src/common/ref_resource_view.h
@@ -76,7 +76,7 @@ class RefResourceView {

[[nodiscard]] size_type size() const { return size_; } // NOLINT
[[nodiscard]] size_type size_bytes() const { // NOLINT
return Span{data(), size()}.size_bytes();
return Span<const value_type>{data(), size()}.size_bytes();
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppleClang11 was unable to deduce the template argument here.

tests/cpp/common/test_io.cc
Comment on lines +151 to +152
auto resource = std::shared_ptr<MmapResource>{
new MmapResource{path, 0, sizeof(double)}};
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue as #9601

@hcho3 hcho3 merged commit afd03a6 into dmlc:release_2.0.0 Oct 18, 2023
21 of 23 checks passed
@hcho3 hcho3 deleted the fix_2.0.0 branch October 18, 2023 16:41
@hcho3 hcho3 mentioned this pull request Oct 18, 2023
Closed
hcho3 added a commit to hcho3/xgboost that referenced this pull request Oct 18, 2023
@hcho3
Fix build for AppleClang 11 (dmlc#9684)
9cc07b1
@hcho3 hcho3 mentioned this pull request Oct 18, 2023
Merged
hcho3 added a commit that referenced this pull request Oct 18, 2023
@hcho3
Fix build for AppleClang 11 (#9684) (#9693)
3b86260
This was referenced Oct 19, 2023
Closed
Merged
@tylerjthomas9 tylerjthomas9 mentioned this pull request Oct 24, 2023
Merged
razdoburdin added a commit to IntelPython/xgboost_oneapi that referenced this pull request Oct 26, 2023
@razdoburdin @trivialfis
@hcho3 @wbo4958
Merge 2.0.1 patch (#7)
89ddb4c 
* [backport] Support pandas 2.1.0. (dmlc#9557) (dmlc#9655)

* [backport] Add support for cgroupv2. (dmlc#9651) (dmlc#9656)

* Bump version to 2.0.1. (dmlc#9660)

* [backport] [CI] Pull CentOS 7 images from NGC (dmlc#9666) (dmlc#9668)

* Fix build for GCC 8.x (dmlc#9670)

* [backport][pyspark] Support stage-level scheduling (dmlc#9519) (dmlc#9686)

Co-authored-by: Bobby Wang <[email protected]>

* Fix build for AppleClang 11 (dmlc#9684)

* Fix libpath logic for Windows (dmlc#9687)

* [CI] Build libxgboost4j.dylib for Intel Mac (dmlc#9704)

* [jvm-packages] Remove hard dependency on libjvm (dmlc#9698) (dmlc#9705)

* Use sys.base_prefix instead of sys.prefix (dmlc#9711)

* Use sys.base_prefix instead of sys.prefix

* Update libpath.py too

---------

Co-authored-by: Jiaming Yuan <[email protected]>
Co-authored-by: Philip Hyunsu Cho <[email protected]>
Co-authored-by: Bobby Wang <[email protected]>
razdoburdin added a commit to IntelPython/xgboost_oneapi that referenced this pull request Oct 26, 2023
@razdoburdin @trivialfis
@hcho3 @wbo4958
Merge xgboost 2.0.1 patch (#9)
ad03395 
* [backport] Support pandas 2.1.0. (dmlc#9557) (dmlc#9655)

* [backport] Add support for cgroupv2. (dmlc#9651) (dmlc#9656)

* Bump version to 2.0.1. (dmlc#9660)

* [backport] [CI] Pull CentOS 7 images from NGC (dmlc#9666) (dmlc#9668)

* Fix build for GCC 8.x (dmlc#9670)

* [backport][pyspark] Support stage-level scheduling (dmlc#9519) (dmlc#9686)

Co-authored-by: Bobby Wang <[email protected]>

* Fix build for AppleClang 11 (dmlc#9684)

* Fix libpath logic for Windows (dmlc#9687)

* [CI] Build libxgboost4j.dylib for Intel Mac (dmlc#9704)

* [jvm-packages] Remove hard dependency on libjvm (dmlc#9698) (dmlc#9705)

* Use sys.base_prefix instead of sys.prefix (dmlc#9711)

* Use sys.base_prefix instead of sys.prefix

* Update libpath.py too

---------

Co-authored-by: Jiaming Yuan <[email protected]>
Co-authored-by: Philip Hyunsu Cho <[email protected]>
Co-authored-by: Bobby Wang <[email protected]>
razdoburdin pushed a commit to IntelPython/xgboost_oneapi that referenced this pull request Oct 26, 2023
@hcho3 @razdoburdin
Fix build for AppleClang 11 (dmlc#9684)
bf36f31
razdoburdin added a commit to razdoburdin/xgboost that referenced this pull request Oct 26, 2023
@razdoburdin @trivialfis
@hcho3 @wbo4958
Merge xgboost 2.0.1 patch (#9)
eafbdb6 
* [backport] Support pandas 2.1.0. (dmlc#9557) (dmlc#9655)

* [backport] Add support for cgroupv2. (dmlc#9651) (dmlc#9656)

* Bump version to 2.0.1. (dmlc#9660)

* [backport] [CI] Pull CentOS 7 images from NGC (dmlc#9666) (dmlc#9668)

* Fix build for GCC 8.x (dmlc#9670)

* [backport][pyspark] Support stage-level scheduling (dmlc#9519) (dmlc#9686)

Co-authored-by: Bobby Wang <[email protected]>

* Fix build for AppleClang 11 (dmlc#9684)

* Fix libpath logic for Windows (dmlc#9687)

* [CI] Build libxgboost4j.dylib for Intel Mac (dmlc#9704)

* [jvm-packages] Remove hard dependency on libjvm (dmlc#9698) (dmlc#9705)

* Use sys.base_prefix instead of sys.prefix (dmlc#9711)

* Use sys.base_prefix instead of sys.prefix

* Update libpath.py too

---------

Co-authored-by: Jiaming Yuan <[email protected]>
Co-authored-by: Philip Hyunsu Cho <[email protected]>
Co-authored-by: Bobby Wang <[email protected]>
razdoburdin pushed a commit to razdoburdin/xgboost that referenced this pull request Oct 26, 2023
@hcho3 @razdoburdin
Fix build for AppleClang 11 (dmlc#9684)
adace73
razdoburdin added a commit to IntelPython/xgboost_oneapi that referenced this pull request Nov 23, 2023
@razdoburdin @trivialfis
@hcho3 @wbo4958
Adopt Patch 2.0.2 (#22)
174492b 
* [backport] Support pandas 2.1.0. (dmlc#9557) (dmlc#9655)

* [backport] Add support for cgroupv2. (dmlc#9651) (dmlc#9656)

* Bump version to 2.0.1. (dmlc#9660)

* [backport] [CI] Pull CentOS 7 images from NGC (dmlc#9666) (dmlc#9668)

* Fix build for GCC 8.x (dmlc#9670)

* [backport][pyspark] Support stage-level scheduling (dmlc#9519) (dmlc#9686)

Co-authored-by: Bobby Wang <[email protected]>

* Fix build for AppleClang 11 (dmlc#9684)

* Fix libpath logic for Windows (dmlc#9687)

* [CI] Build libxgboost4j.dylib for Intel Mac (dmlc#9704)

* [jvm-packages] Remove hard dependency on libjvm (dmlc#9698) (dmlc#9705)

* Use sys.base_prefix instead of sys.prefix (dmlc#9711)

* Use sys.base_prefix instead of sys.prefix

* Update libpath.py too

* [backport] Fix using categorical data with the ranker. (dmlc#9753) (dmlc#9778)

* [jvm-packages] Add Scala version suffix to xgboost-jvm package (dmlc#9776)

* Update JVM script (dmlc#9714)

* Bump version to 2.0.2; revamp pom.xml

* Update instructions in prepare_jvm_release.py

* Fix formatting

* fix merging for R-package/configure

---------

Co-authored-by: Jiaming Yuan <[email protected]>
Co-authored-by: Philip Hyunsu Cho <[email protected]>
Co-authored-by: Bobby Wang <[email protected]>
Co-authored-by: Dmitry Razdoburdin <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivialfis trivialfis trivialfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hcho3 @trivialfis