Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] address some lintr warnings #8609

Merged
merged 2 commits into from
Dec 17, 2022
Merged

Conversation

jameslamb
Copy link
Contributor

Contributes to #8012 .

Resolves the following R linting warnings.

style: [infix_spaces_linter] Put spaces around all infix operators.
style: [spaces_left_parentheses_linter] Place a space before left parenthesis, except in a function call.
style: [commas_linter] Commas should always have a space after.
style: [semicolon] Trailing semicolons are not needed.
style: [trailing_whitespace_linter] Trailing whitespace is superfluous.

How I tested this

Ran the linter with the following code.

Rscript tests/ci_build/lint_r.R $(pwd)

Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the nice work! We are very close to addressing all the linter warnings!

@trivialfis trivialfis merged commit 17ce1f2 into dmlc:master Dec 17, 2022
@jameslamb jameslamb deleted the r/formatting branch December 19, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants