-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmarks to track performance changes in 'hist' method #5126
Conversation
@RAMitchell We staged many benchmarking scripts in external projects. I also have a collection of them with dask. I'm open to have some of those XGBoost specific scripts to be maintained in one place. WDYT? |
Time by kernels after optimizations reverting collected by the benchmarks:
Time by kernels before optimizations reverting:
HW: c5.metal AWS instance |
As this becomes more sophisticated it begs the question, should this code be inside the xgboost main repo? It has no dependency on xgboost source code, only on having some installed version of xgboost. We can just as easily run it via our CI as a separate repo. Also how is this different from https://github.com/NVIDIA/gbm-bench? Would you get the information you need by running this? Maybe we need a more neutrally hosted version of gbm-bench. |
Also, one of the problems with previous optimisations was that they caused performance regression in the distributed algorithm due to increasing the number of rabit calls. To resolve this we could run experiments with dask. |
@RAMitchell We can probably combine NVIDIA/gbm-bench and this pull request. For now, let us just benchmark XGBoost and not worry about other libraries (LightGBM, CatBoost etc). And as you mentioned, we should definitely test distributed training. @tqchen Can I have admin right over https://github.com/dmlc/xgboost-bench ? This seems perfect for hosting benchmark script. |
@dmlc/xgboost-committer https://github.com/dmlc/xgboost-bench is now public. All committers of XGBoost should have push access to it. |
Closing this PR now. I will move this PR code to https://github.com/dmlc/xgboost-bench |
@SmirnovEgorRu I moved your benchmark code to xgboost-bench repo: dmlc/xgboost-bench@c787a59 |
It is PR №2 from the issue #5104.
It is required to understand impact of the optimizations. I'm planning to use them for all further PRs.