Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make C++ unit tests run and pass on Windows #3869

Merged
merged 3 commits into from
Nov 7, 2018
Merged

Make C++ unit tests run and pass on Windows #3869

merged 3 commits into from
Nov 7, 2018

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Nov 5, 2018

  • Fix logic for external memory. The letter ':' is part of drive letter, so remove the drive letter before splitting on ':'.
  • Cosmetic syntax changes to keep MSVC happy.

Fixes #3038.

@hcho3 hcho3 mentioned this pull request Nov 5, 2018
Closed
@hcho3
Make C++ unit tests run and pass on Windows
44f8cb5 
* Fix logic for external memory. The letter ':' is part of drive letter,
so remove the drive letter before splitting on ':'.
* Cosmetic syntax changes to keep MSVC happy.
@hcho3
Copy link
Collaborator Author

hcho3 commented Nov 6, 2018

It turns out std::regex is not supported in GCC 4.8.2.

@hcho3
Copy link
Collaborator Author

hcho3 commented Nov 6, 2018

@trivialfis Can you take a look?

trivialfis
trivialfis reviewed Nov 6, 2018
View reviewed changes
Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I'm not sure since I have never done anything beyond hello world on Windows. Sorry about that.

src/data/sparse_page_source.cc Outdated Show resolved Hide resolved
@hcho3 hcho3 merged commit 2b045aa into dmlc:master Nov 7, 2018
@hcho3 hcho3 deleted the fix_win_test branch November 7, 2018 01:17
@lock lock bot locked as resolved and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trivialfis trivialfis trivialfis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hcho3 @trivialfis