Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract array interface handlers. #11089

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Extract array interface handlers. #11089

merged 4 commits into from
Dec 11, 2024

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Dec 11, 2024 •
edited
Loading

  • Extract helper functions into a different module.
  • Define typed dictionary for type check.

@trivialfis
Extract array interface handlers.
41f75ed 
- Extract helper functions into a different module.
- Defined typed dictionary for type check.
@trivialfis trivialfis requested a review from hcho3 December 11, 2024 10:43
wphicks
wphicks approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@trivialfis trivialfis merged commit 6c2d5b3 into dmlc:master Dec 11, 2024
59 checks passed
@trivialfis trivialfis deleted the py-arr-inf branch December 11, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wphicks wphicks wphicks approved these changes

@hcho3 hcho3 Awaiting requested review from hcho3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @wphicks