Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Use supported versions of Windows #381

Merged
merged 2 commits into from
May 15, 2022
Merged

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented May 14, 2022

The vs2017-win2016 image was retired on last March. Use windows-2019 for all Windows jobs.

@codecov
Copy link

codecov bot commented May 15, 2022

Codecov Report

Merging #381 (07166a8) into mainline (4cc4f7e) will increase coverage by 0.09%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             mainline     #381      +/-   ##
==============================================
+ Coverage       84.85%   84.94%   +0.09%     
- Complexity         42       44       +2     
==============================================
  Files             108      106       -2     
  Lines            8663     7574    -1089     
  Branches          510       40     -470     
==============================================
- Hits             7351     6434     -917     
+ Misses           1289     1116     -173     
- Partials           23       24       +1     
Impacted Files Coverage Δ
python/treelite/libpath.py 75.00% <0.00%> (-7.15%) ⬇️
runtime/python/treelite_runtime/libpath.py 75.00% <0.00%> (-7.15%) ⬇️
include/treelite/base.h 52.17% <0.00%> (-5.52%) ⬇️
src/compiler/native/typeinfo_ctypes.h 42.10% <0.00%> (-4.67%) ⬇️
src/frontend/xgboost/xgboost_json.h 83.82% <0.00%> (-4.14%) ⬇️
src/compiler/ast/ast.h 34.92% <0.00%> (-3.91%) ⬇️
src/typeinfo.cc 75.00% <0.00%> (-2.78%) ⬇️
runtime/python/treelite_runtime/util.py 92.10% <0.00%> (-2.64%) ⬇️
src/compiler/pred_transform.cc 66.66% <0.00%> (-2.57%) ⬇️
include/treelite/optional.h 85.71% <0.00%> (-2.53%) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc4f7e...07166a8. Read the comment docs.

@hcho3 hcho3 merged commit fcb8ad2 into dmlc:mainline May 15, 2022
@hcho3 hcho3 deleted the update_ci branch May 15, 2022 00:23
This was referenced May 23, 2022
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request May 28, 2022
The 2.4.0 version of Treelite incorporates the following improvements:

* dmlc/treelite#370
* dmlc/treelite#381
* dmlc/treelite#380
* dmlc/treelite#383

Requires rapidsai/integration#474

This PR targets the 22.06 release.

Closes #4715

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #4752
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
The 2.4.0 version of Treelite incorporates the following improvements:

* dmlc/treelite#370
* dmlc/treelite#381
* dmlc/treelite#380
* dmlc/treelite#383

Requires rapidsai/integration#474

This PR targets the 22.06 release.

Closes rapidsai#4715

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant