Handle the case where left_categories={} #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## mainline #303 +/- ##
==============================================
- Coverage 85.18% 85.16% -0.03%
Complexity 46 46
==============================================
Files 108 108
Lines 8156 8161 +5
Branches 50 50
==============================================
+ Hits 6948 6950 +2
- Misses 1183 1186 +3
Partials 25 25
Continue to review full report at Codecov.
|
This was referenced Sep 20, 2021
Merged
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Sep 23, 2021
The 2.1.0 version of Treelite incorporates the following major improvements: * dmlc/treelite#311 * dmlc/treelite#302 * dmlc/treelite#303 * dmlc/treelite#296 In particular, dmlc/treelite#311 is a critical follow-up to #4191 and addresses a performance regression. Requires rapidsai/integration#353 Authors: - Philip Hyunsu Cho (https://github.com/hcho3) Approvers: - Jordan Jacobelli (https://github.com/Ethyling) - Dante Gama Dessavre (https://github.com/dantegd) URL: #4220
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
The 2.1.0 version of Treelite incorporates the following major improvements: * dmlc/treelite#311 * dmlc/treelite#302 * dmlc/treelite#303 * dmlc/treelite#296 In particular, dmlc/treelite#311 is a critical follow-up to rapidsai#4191 and addresses a performance regression. Requires rapidsai/integration#353 Authors: - Philip Hyunsu Cho (https://github.com/hcho3) Approvers: - Jordan Jacobelli (https://github.com/Ethyling) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4220
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was revealed in rapidsai/cuml#4041. When the user is iteratively building a model using the model builder class and specifies a categorical split with an empty value
{}forleft_categories, Treelite throws an exceptionThis PR ensures that Treelite can represent categorical splits with empty left categories.