Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored table in csv form for better readability and organization #1465

Merged
merged 2 commits into from
Sep 30, 2020

Conversation

yinweisu
Copy link
Collaborator

Current rst table is written in a way that's hard to read and maintain. Hence, I refactored the table structure to take in csv files instead. Future changes to the table can be made easily through csv files.

@mli
Copy link
Member

mli commented Sep 29, 2020

Job PR-1465-1 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-1465/1/index.html
Code coverage of this PR: pr.svg vs. Master: master.svg

@bryanyzhu
Copy link
Collaborator

Current rst table is written in a way that's hard to read and maintain. Hence, I refactored the table structure to take in csv files instead. Future changes to the table can be made easily through csv files.

Life saver!

@mli
Copy link
Member

mli commented Sep 30, 2020

Job PR-1465-2 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-1465/2/index.html
Code coverage of this PR: pr.svg vs. Master: master.svg

@zhreshold zhreshold merged commit 4a2e2ae into dmlc:master Sep 30, 2020
@yinweisu yinweisu deleted the table_refactor branch September 30, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants