Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't populate labels if label column is not specified in csv parser #679

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Don't populate labels if label column is not specified in csv parser #679

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9142ba
Don't populate labels if label column is not specified in csv parser
rongou Mar 6, 2023
60fb4ca
simplify label handling
rongou Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/data/csv_parser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,8 @@ struct CSVParserParam : public Parameter<CSVParserParam> {

/*!
* \brief CSVParser, parses a dense csv format.
* Currently is a dummy implementation, when label column is not specified.
* All columns are treated as real dense data.
* label will be assigned to 0.
* Label will be empty if the label column is not specified.
*
* This should be extended in future to accept arguments of column types.
*/
Expand Down Expand Up @@ -90,7 +89,6 @@ ParseBlock(const char *begin,
const char* p = lbegin;
int column_index = 0;
IndexType idx = 0;
DType label = DType(0.0f);
real_t weight = std::numeric_limits<real_t>::quiet_NaN();

while (p != lend) {
Expand All @@ -111,7 +109,7 @@ ParseBlock(const char *begin,
}

if (column_index == param_.label_column) {
label = v;
out->label.push_back(v);
} else if (std::is_same<DType, real_t>::value
&& column_index == param_.weight_column) {
weight = v;
Expand All @@ -136,13 +134,12 @@ ParseBlock(const char *begin,
// skip empty line
while ((*lend == '\n' || *lend == '\r') && lend != end) ++lend;
lbegin = lend;
out->label.push_back(label);
if (!std::isnan(weight)) {
out->weight.push_back(weight);
}
out->offset.push_back(out->index.size());
}
CHECK(out->label.size() + 1 == out->offset.size());
CHECK(out->label.size() == 0 || out->label.size() + 1 == out->offset.size());
CHECK(out->weight.size() == 0 || out->weight.size() + 1 == out->offset.size());
}
} // namespace data
Expand Down