Skip to content

Commit

Permalink
Don't use jcenter.bintray.com in test, it is sort of EOL (bazel-contr…
Browse files Browse the repository at this point in the history
…ib#657)

Replace with https://repo1.maven.org/maven2

Test can time out fetching from jcenter like in
https://buildkite.com/bazel/rules-jvm-external/builds/2461#c70711ec-e59f-48e9-b925-7d755a014070

It seems that in the end it is supposed to be maintained as read-only but atm times out
https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/
  • Loading branch information
dmivankov authored Jan 18, 2022
1 parent 77225e0 commit cbc10ce
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ maven_install(
"com.google.code.findbugs:jsr305:3.0.2",
],
repositories = [
"https://jcenter.bintray.com/",
"https://repo1.maven.org/maven2",
],
)

Expand All @@ -447,7 +447,7 @@ maven_install(
"com.android.support:appcompat-v7:28.0.0",
],
repositories = [
"https://jcenter.bintray.com/",
"https://repo1.maven.org/maven2",
"https://maven.google.com",
],
fetch_sources = False,
Expand All @@ -463,7 +463,7 @@ maven_install(
"com.android.support:appcompat-v7:28.0.0",
],
repositories = [
"https://jcenter.bintray.com/",
"https://repo1.maven.org/maven2",
"https://maven.google.com",
],
use_starlark_android_rules = True,
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/jvm_import/jvm_import_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def _does_jvm_import_have_tags_impl(ctx):

expected_tags = [
"maven_coordinates=com.google.code.findbugs:jsr305:3.0.2",
"maven_url=https://jcenter.bintray.com/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar",
"maven_url=https://repo1.maven.org/maven2/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar",
]

asserts.equals(env, ctx.attr.src[TagsInfo].tags, expected_tags)
Expand Down

0 comments on commit cbc10ce

Please sign in to comment.