Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for o200k_base and gpt-4o (omni) model #41

Closed
wants to merge 5 commits into from
Closed

Support for o200k_base and gpt-4o (omni) model #41

wants to merge 5 commits into from

Conversation

winzig
Copy link
Contributor

@winzig winzig commented May 15, 2024

Notes:

  • I added in the new test plans for o200k based on output from tiktoken
  • I added a SetupO200k() in CompareBenchmark (and renamed Setup to SetupCL200k), but it's not flagged as the GlobalSetup, so not currently used/benchmarked. Wasn't sure if you wanted to re-benchmark with the new encoding?

This was referenced May 15, 2024
Closed
Closed
winzig added 3 commits May 15, 2024 12:24
@winzig
Fixing typo
5cf058b 
Accidentally removed a using statement in my last update
@winzig
Fixed issue with some tests
c23934f 
Still failing in a handful of tests of the new o200k
@winzig
All tests now passing (fixed typo)
6942171
@winzig
Copy link
Contributor Author

winzig commented May 15, 2024

Fixed some issues that I found, all tests now passing.

@dmitry-brazhenko
Copy link
Owner

Thank you so much for contribution!

@dmitry-brazhenko
Copy link
Owner

dmitry-brazhenko commented May 17, 2024 •
edited
Loading

I added minor fixes around failed tests in macos pipeline and will merge it here: #43

@dmitry-brazhenko dmitry-brazhenko mentioned this pull request May 17, 2024
Merged
@dmitry-brazhenko
Copy link
Owner

Did it here: #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winzig @dmitry-brazhenko